Skip to content

Upgrade urllib to undici 8 while preserving default HTTP/1.1 behavior#766

Draft
Copilot wants to merge 10 commits intomasterfrom
copilot/upgrade-undici-8
Draft

Upgrade urllib to undici 8 while preserving default HTTP/1.1 behavior#766
Copilot wants to merge 10 commits intomasterfrom
copilot/upgrade-undici-8

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

  • Inspect the latest failing CI run and identify the current failing job/test
  • Reproduce the failure locally with targeted validation
  • Make the smallest fix for the failing behavior
  • Re-run targeted checks/tests and final validation
  • Reply on the PR comment with the addressing commit hash

Copilot AI linked an issue May 8, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits May 8, 2026 05:51
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 8, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedundici@​7.25.0 ⏵ 8.2.072 +1100100 +198 +2100

View full report

Copilot AI changed the title [WIP] Update to undici@8 and set Node.js min version to 22.19.0 Upgrade urllib to undici 8 while preserving default HTTP/1.1 behavior May 8, 2026
Copilot finished work on behalf of fengmk2 May 8, 2026 05:55
Copilot AI requested a review from fengmk2 May 8, 2026 05:55
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 8, 2026

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@766

commit: aaa230e

@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented May 8, 2026

@copilot ci fails

Copilot AI and others added 3 commits May 8, 2026 06:52
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 8, 2026

@copilot ci fails

Fixed in aaa230e. I investigated the failing Actions run and updated test/options.dispatcher.test.ts to avoid the flaky external HTTPS path and to close created ProxyAgent instances during teardown, which was causing the suite to hang in CI.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • registry.npmmirror.com
    • Triggering command: /home/REDACTED/.npm/_npx/992a19d7d9bf36d4/node_modules/node/bin/node /home/REDACTED/.npm/_npx/992a19d7d9bf36d4/node_modules/node/bin/node --experimental-import-meta-resolve --require /home/REDACTED/work/urllib/urllib/node_modules/.pnpm/@voidzero-dev+vite-plus-test@0.1.20_@arethetypeswrong+core@0.18.2_@types+node@22.19.17__be9d289fb071b59767ee3a2ed415b245/node_modules/@voidzero-dev/vite-plus-test/suppress-warnings.cjs --conditions node --conditions development /home/REDACTED/work/urllib/urllib/node_modules/.pnpm/@voidzero-dev+vite-plus-test@0.1.20_@arethetypeswrong+core@0.18.2_@types+node@22.19.17__be9d289fb071b59767ee3a2ed415b245/node_modules/@voidzero-dev/vite-plus-test/dist/workers/forks.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of fengmk2 May 8, 2026 06:57
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented May 9, 2026

@copilot ci fails

Copilot AI and others added 4 commits May 9, 2026 05:41
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 9, 2026

@copilot ci fails

Fixed in d2d0156. The current CI failure was a MockAgent regression from the default dispatcher change in HttpClient; default requests now keep urllib’s HTTP/1.1-safe dispatcher unless the global undici dispatcher has been explicitly overridden, so the mocking tests pass again.

Copilot finished work on behalf of fengmk2 May 9, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade to undici@8

2 participants