Repository navigation
Update Hardware Manager references and device screenshots in README - #76
Merged
shihan-teo-NI merged 3 commits intoOct 19, 2026
Merged
shihan-teo-NI merged 3 commits into
shihan-teo-NI merged 3 commits into
Conversation
Signed-off-by: Shihan Teo <shihan.teo@emerson.com> Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
shihan-teo-NI
requested review from
a team,
CHrislian-NI,
jonnysoe,
tkrebes and
tsengguanyung
as code owners
October 16, 2026 03:37
tsengguanyung
approved these changes
Oct 19, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Both screenshot links break when the README is published as the PyPI package description.
1 open issue
What changed in this PR
Updates the package’s device-setup documentation to use current NI Hardware Manager branding.
Changes:
- Replaces Hardware Configuration Utility references and screenshot alt text.
- Changes both screenshot URLs to repository-relative paths.
| File | Description |
|---|---|
| README.md | Updates hardware-tool branding and screenshot links. |
Review effort: Balanced
jonnysoe
approved these changes
Oct 19, 2026
Signed-off-by: Shihan Teo <shihan.teo@emerson.com> Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Shihan Teo <shihan.teo@emerson.com> Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tsengguanyung
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
aw.githubusercontent.com URLs so screenshots render both on GitHub and in the PyPI package description.
Why should this Pull Request be merged?
Aligns documentation and screenshots with current NI software branding (Hardware Manager) while keeping PyPI image links working.
What testing has been done?
Verified Markdown rendering and confirmed raw image URLs return HTTP 200.