test(playwright): migrate propfind tests from Cypress to Playwright - #9021
test(playwright): migrate propfind tests from Cypress to Playwright#9021mejo- wants to merge 2 commits into
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
|
/backport to stable34 |
|
/backport to stable33 |
Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
0282101 to
b9c8505
Compare
| const [root1] = await propfindFolder(user, '/', 0, properties) | ||
| expect(root1).toHaveProperty(PROPERTY_WORKSPACE_FLAT, '') | ||
|
|
||
| await deleteWebDAVResource(user, '/Readme.md') |
There was a problem hiding this comment.
This line most likely fixes the flakiness of the test compared to the Cypress one. Without this line, this test succeeds reliably locally but fails reliably (so far) in CI.
Claude assumes that this is because the storage cache doesn't get invalidated properly in CI when only overwriting the file compared to deleting it and uploading a new file (which results in new fileId etc). It may well be that the missing cache invalidation is due to different APCu caching setup in CI.
There was a problem hiding this comment.
I wonder if we could fix that different setup. Would such a setup have visible consequences in actual setups or is this a CI artifact we are observing?
There was a problem hiding this comment.
I don't have hard feelings here. I didn't dive into investigating the actual differences with caching setup between CI and local environment, I merely was happy to have found an explanation for the flaky test and decided to move on 😆
There was a problem hiding this comment.
@max-nextcloud do you see a problem with adding the delete in the test? It arguably changes what is being tested: updating a file no longer is tested. But do you think it should be tested in the propfind tests?
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
…slow The test often exceeds the default timeout in CI. Signed-off-by: Jonas <jonas@freesources.org>
2 participants
Assisted-by: OpenCode:claude-fable-5
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)