Skip to content

fix: improve socket validation - #9860

Open
Rello wants to merge 5 commits into
masterfrom
Rello-patch-1
Open

fix: improve socket validation#9860
Rello wants to merge 5 commits into
masterfrom
Rello-patch-1

Conversation

@Rello

@Rello Rello commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

fix: improve socket validation

@Rello
Rello marked this pull request as draft April 17, 2026 10:39
@Rello Rello added this to the 33.0.3 milestone Apr 17, 2026
@Rello
Rello marked this pull request as ready for review April 20, 2026 12:53
@sonarqubecloud

sonarqubecloud Bot commented Apr 23, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Coverage on New Code (required ≥ 80%)
76 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien

mgallien commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

for now, I had an issue with this PR

2026-04-23 12:10:38:866 [ warning nextcloud.gui.socketapi C:\Nextcloud\desktop\src\gui\socketapi\socketapi.cpp:239 ]:	Could not send all data on socket for  "REGISTER_PATH:C:\\Users\\Matthieu Gallien\\Nextcloud7\n"
2026-04-23 12:10:42:178 [ critical default C:\Nextcloud\desktop\src\gui\socketapi\socketapi.cpp:331 ]:	ASSERT: "socket->readAll().isEmpty()" in file C:\Nextcloud\desktop\src\gui\socketapi\socketapi.cpp, line 331
2026-04-23 12:10:42:178 [ warning nextcloud.gui.socketapi C:\Nextcloud\desktop\src\gui\socketapi\socketapi.cpp:239 ]:	Could not send all data on socket for  "REGISTER_PATH:C:\\Users\\Matthieu Gallien\\Nextcloud7\n"

@mgallien

mgallien commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

will need investigation

@mgallien mgallien modified the milestones: 33.0.3, 33.0.4 Apr 27, 2026
@nilsding nilsding modified the milestones: 33.0.4, 33.0.5 May 4, 2026
@nilsding nilsding modified the milestones: 33.0.5, 33.0.6 May 19, 2026
@mgallien mgallien modified the milestones: 33.0.6, 34.0.0 Jun 18, 2026
claucambra
claucambra requested changes Jul 16, 2026
View reviewed changes

@claucambra claucambra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on @mgallien feedback I am marking this as needing changes

Rello and others added 5 commits July 20, 2026 13:59
@Rello @mgallien
fix: improve socket validation
7eb7726 
Signed-off-by: Rello <Rello@users.noreply.github.com>
@Rello @mgallien
Fix indentation in socketapi.cpp
d77a52c 
Signed-off-by: Rello <Rello@users.noreply.github.com>
@mgallien
fix(share): ask for confirmation before leaving a share
496b3d7 
there is no way to undo leaving a share. Better ask users for
confirmation

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@Rello @mgallien
Update socketapi.cpp
b7700d3 
Signed-off-by: Rello <Rello@users.noreply.github.com>
@mgallien
fix(leaveShare): do not interact with user in automated tests
39499e4 
automated tests of leaveShare are run without graphical user interaction
possibnilities

ensure the tests will not try to create QWidget items preventing a crash

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9860.zip

Digest: sha256:b6be84e7a1f6e912205842e72bd36fecaea1868b666e5060c6e20846840ede27

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Jul 20, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
85 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

@mgallien mgallien modified the milestones: 34.0.0, 34.0.1 Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claucambra claucambra claucambra requested changes
@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio
@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner
@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner
@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner
@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@mgallien mgallien

Labels

None yet

Projects

None yet

Milestone

34.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Rello @mgallien @claucambra @nilsding