Skip to content

Update nuspec to place library under nano TFM#40

Merged
josesimoes merged 2 commits into
developfrom
copilot/update-nuspec-for-netnano
Mar 4, 2026
Merged

Update nuspec to place library under nano TFM#40
josesimoes merged 2 commits into
developfrom
copilot/update-nuspec-for-netnano

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 4, 2026

NuGet package files were being placed under lib instead of lib\netnano1.0, and the dependency lacked a target framework group, causing incorrect TFM resolution for .NETnanoFramework1.0 consumers.

Changes

  • Dependency group: Wrapped nanoFramework.CoreLibrary dependency in <group targetFramework=".NETnanoFramework1.0"> to properly declare the nano TFM dependency group
  • File target path: Changed file target from lib\<filename>lib\netnano1.0
  • Wildcard consolidation: Replaced five individual <file> entries (.dll, .pdb, .pdbx, .pe, .xml) with a single wildcard entry
<!-- Before -->
<dependencies>
  <dependency id="nanoFramework.CoreLibrary" version="2.0.0-preview.35" />
</dependencies>
<files>
  <file src="...\Release\System.Runtime.Serialization.dll" target="lib\System.Runtime.Serialization.dll" />
  <file src="...\Release\System.Runtime.Serialization.pdbx" target="lib\System.Runtime.Serialization.pdbx" />
  <!-- ... -->
</files>

<!-- After -->
<dependencies>
  <group targetFramework=".NETnanoFramework1.0">
    <dependency id="nanoFramework.CoreLibrary" version="2.0.0-preview.35" />
  </group>
</dependencies>
<files>
  <file src="nanoFramework.System.Runtime.Serialization\bin\Release\System.Runtime.Serialization.*" target="lib\netnano1.0" />
</files>
Original prompt

This section details on the original issue you should resolve

<issue_title>Update nuspec to place library under nano TFM</issue_title>
<issue_description>### Details about task
Most of the nuspec files are not using the correct location to place the files.
Files (DLL, PE, PDBX and XML for IntelliSense) should be placed under "lib\netnano1.0" (currently are being placed under "lib" only.
Also they should declare a dependency group for ".NETnanoFramework1.0" target framework.
At the same time those still naming the various file types should use a wildcard instead (e.g. "...\Release\mscorlib.*).
The correct pattern should be (take this nuspec as sample):
nanoframework/System.Device.Adc@aab7bca

Do not change anything else on the nuspec file.

Description

</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
Copilot AI changed the title [WIP] Update nuspec to place library under nano TFM Update nuspec to place library under nano TFM Mar 4, 2026
@josesimoes josesimoes marked this pull request as ready for review March 4, 2026 18:59
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 4, 2026

@josesimoes josesimoes merged commit 17cf9ef into develop Mar 4, 2026
8 of 10 checks passed
@josesimoes josesimoes deleted the copilot/update-nuspec-for-netnano branch March 4, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants