Repository navigation
Order transaction smart contract results and operations by execution - #1638
Merged
Merged
Conversation
|
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…lback, cross-shard events order
claudiulataretu
approved these changes
Oct 7, 2026
radumojic
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
timestampMs.uuid, which does not reflect execution.operationscame out in arbitrary order: events were not sorted byorder, SCR operations were always placed before log operations, andtrimOperationsmoved the sender's operations to the top.logsindex is deprecated and removed.Proposed Changes
timestampMstoSmartContractResult. When it is missing, it falls back totimestamp * 1000. Addednonceas a sort tie-breaker for SCRs.features.chainSupernovaconfig (enabled,activationTimestampMs) and thescResultsOrderedByExecutionquery param onGET /transactions/:txHash, defaultfalse.executionOrderTxsIndices. The indices are read fromblocksbefore Supernova and fromexecutionresultsafter.events, sorted byorderin elastic.trimOperations; deduplication is unchanged.logsindex path andelasticMigratedIndices.multiversx/elastic-indexercontainer, so theexecutionresultsindex exists.How to test
GET /transactions/2be7d7e40df1c7eb84c7dc2103669fce0b4639d92789c18c926f8d31fc4a5b3b?scResultsOrderedByExecution=true(post-Supernova):resultsandoperationsfollow the swap flow, with cross-shard fee SCRs between the swaps.GET /transactions/0e21b0d3dd439689a9c254168ce613aaa7acd424f4e0b8fcb4628fac99235c1d?scResultsOrderedByExecution=true(pre-Supernova):resultsfollow the execution indices fromblocks.GET /transactions/ea9c62431d0eb7aecbf41467980c9ac086d645510e3e9714d3d3ff811b49926f: the sender'swriteLogis the last operation.