Fix the output pass cache for multi-canvas rendering#33209
Closed
arodic wants to merge 1 commit intomrdoob:devfrom
Closed
Fix the output pass cache for multi-canvas rendering#33209arodic wants to merge 1 commit intomrdoob:devfrom
arodic wants to merge 1 commit intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This was referenced Mar 18, 2026
Collaborator
|
Closing in favor of #33228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #32689
Description
#32690 introduced regression that caused webgpu_multiple_canvas to render same output to all canvases where each canvas should have unique output buffer.
the problem is that this line returns false negative because it only represents output config from
getOutputCacheKey(): tone mapping, color space, XR state It does not encode which texture is currently boundThis fix, however feels more like a band-aid rather than something that addresses the real issue. The caching mechanism relies on a cacheKey that does not correctly check for the identity of the target being cached.
I'm submitting this as draft and looking for better solution.