Rename AudioContext to AudioContextProvider#33208
Closed
PoseidonEnergy wants to merge 1 commit intomrdoob:devfrom
Closed
Rename AudioContext to AudioContextProvider#33208PoseidonEnergy wants to merge 1 commit intomrdoob:devfrom
AudioContext to AudioContextProvider#33208PoseidonEnergy wants to merge 1 commit intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
|
Sorry, but I don't think the renaming is worth the breakage and migration effort. Better to fix the JSDoc instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #33206
Description
Rename
AudioContexttoAudioContextProviderso JSDoc references the correct types in info hover tooltips. There is already an existingwindow.AudioContexttype that trips IDEs up.