Skip to content

Helpers: Clarify the usage of update().#32717

Merged
Mugen87 merged 4 commits intomrdoob:devfrom
Mugen87:dev4
Jan 12, 2026
Merged

Helpers: Clarify the usage of update().#32717
Mugen87 merged 4 commits intomrdoob:devfrom
Mugen87:dev4

Conversation

@Mugen87
Copy link
Copy Markdown
Collaborator

@Mugen87 Mugen87 commented Jan 11, 2026

Fixed #32713.

Description

As suggested in #32713 (comment), the PR clarifies the usage of update() method in some helper classes.

@Mugen87 Mugen87 requested a review from WestLangley January 11, 2026 11:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 11, 2026

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 355.41
84.51
355.41
84.51
+0 B
+0 B
WebGPU 621.22
172.51
621.22
172.51
+0 B
+0 B
WebGPU Nodes 619.83
172.28
619.83
172.28
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 487.36
119.29
487.36
119.29
+0 B
+0 B
WebGPU 691.88
187.8
691.88
187.8
+0 B
+0 B
WebGPU Nodes 641.68
174.96
641.68
174.96
+0 B
+0 B

@Mugen87 Mugen87 added this to the r183 milestone Jan 11, 2026
Comment thread src/helpers/DirectionalLightHelper.js Outdated
@Mugen87 Mugen87 merged commit 2ec2102 into mrdoob:dev Jan 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

directional light camera helper is distorted

2 participants