Skip to content

Sky/SkyMesh: Remove legacy gamma correction curve.#32677

Merged
mrdoob merged 2 commits intodevfrom
sky
Jan 6, 2026
Merged

Sky/SkyMesh: Remove legacy gamma correction curve.#32677
mrdoob merged 2 commits intodevfrom
sky

Conversation

@mrdoob
Copy link
Copy Markdown
Owner

@mrdoob mrdoob commented Jan 6, 2026

Related issue: #32325

Description

Removed the adaptive gamma curve that was applied before tonemapping. The shaders now output linear values, letting the renderer's tonemapping and color space conversion handle the display transform correctly.

This curve was a legacy artifact from before Three.js had proper color management. Applying it before tonemapping meant the tonemapper was operating on non-linear data.

(Made with Claude Opus 4.5)

@mrdoob mrdoob added this to the r183 milestone Jan 6, 2026
@mrdoob mrdoob merged commit da18e06 into dev Jan 6, 2026
9 checks passed
@mrdoob mrdoob deleted the sky branch January 6, 2026 13:09
@kungfooman
Copy link
Copy Markdown

Suddenly my sky looks like doomsday and I can't figure out options for a normal "daylight" sky.

I also tried to increase like renderer.toneMappingExposure = 2 (but it just makes everything look grayed out somehow)

Any solution for nice daylight sky?

@Mugen87
Copy link
Copy Markdown
Collaborator

Mugen87 commented Feb 25, 2026

Maybe like so: https://jsfiddle.net/zxr2c4dv/

If you want the sky a bit more blue, reduce the rayleigh parameter e.g. to 0.5.

@kungfooman
Copy link
Copy Markdown

Thank you @Mugen87 great example, I didn't even know the clouds can be animated ☁️ 🌈

Sadly it still looks like doomsday:

image

Previous sky was looking like "clear bright day"

I think you are changing as we write, now it is suddenly full white:

image

Thank you for working on it!

@Mugen87
Copy link
Copy Markdown
Collaborator

Mugen87 commented Feb 25, 2026

Please try the link again and also us the controls to look around. I have not saved the fiddle correctly when posted the comment.

@kungfooman
Copy link
Copy Markdown

Thank you @Mugen87 I just still have a big problem with it. This is how it looked before:

image

As you can see, the camera is "above" sea level and you can still see the grid very clearly.

In your jsfiddle I have to drag the orbit camera below sea level, otherwise it's basically just full bright and you won't see the grid:

image

I always loved the Three sky because it looked so serene with soft pastell gradients and now it just looks like doomsday or "too bright".

@Mugen87
Copy link
Copy Markdown
Collaborator

Mugen87 commented Feb 25, 2026

The removal of the previous built-in gamma correction has significantly changed the effect's visual. If you are not able to restore a similar look via the parameters, I'm afraid you have to use a custom version of the previous implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants