Skip to content

Fix obsolete Google Translate locale link - #4523

Merged
flodolo merged 2 commits into
mozilla:mainfrom
tahakotil:fix/google-translate-link-4519
Sep 17, 2026
Merged

flodolo merged 2 commits into
mozilla:mainfrom
tahakotil:fix/google-translate-link-4519

Conversation

@tahakotil

Copy link
Copy Markdown
Contributor

Summary

  • replace the obsolete Google Translate locales link with the official Cloud Translation language-support page
  • update both Django admin help text and administrator documentation
  • add the matching Django field-state migration

Verification

  • confirmed the replacement is the current official Cloud Translation language-support page
  • ruff check pontoon/base/models/locale.py pontoon/base/migrations/0134_alter_locale_google_translate_code.py
  • parsed both changed Python files with ast.parse
  • git diff --check

AI assistance: Codex was used to implement and verify this change under @tahakotil's direction.

Fixes #4519

Replace the obsolete redirect with the official Cloud Translation language-support page. Keep the Django field state in sync with an AlterField migration.
@mathjazz
mathjazz requested a review from flodolo September 14, 2026 07:52
### Google Translate code

Google Translate maintains a list of supported locales in its own format. Choose one that matches the locale from [a list of supported locales](https://translate.google.com/intl/en/about/languages/) or leave it blank to disable support for Google Translate for this locale.
Google Cloud Translation maintains a list of supported locales in its own format. Choose one that matches the locale from [the list of supported languages](https://cloud.google.com/translate/docs/languages) or leave it blank to disable support for Google Cloud Translation for this locale.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link redirects to https://docs.cloud.google.com/translate/docs/languages
We should point to the final URL and skip the redirect

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in efc6278 — both links (docs + admin help text) now point to https://docs.cloud.google.com/translate/docs/languages, with the field-state migration updated to match.

@flodolo

flodolo commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

@tahakotil
Checking in: are you able to complete this?

@tahakotil

Copy link
Copy Markdown
Contributor Author

@flodolo apologies for the delay — updated in efc6278.

The link now points directly to the final URL (https://docs.cloud.google.com/translate/docs/languages) in the administrator docs, the google_translate_code help text, and its field-state migration. ruff check and git diff --check pass, and I confirmed the old URL 301-redirects to the new one (200).

Ready for another look.

### Google Translate code

Google Translate maintains a list of supported locales in its own format. Choose one that matches the locale from [a list of supported locales](https://translate.google.com/intl/en/about/languages/) or leave it blank to disable support for Google Translate for this locale.
Google Cloud Translation maintains a list of supported locales in its own format. Choose one that matches the locale from [the list of supported languages](https://docs.cloud.google.com/translate/docs/languages) or leave it blank to disable support for Google Cloud Translation for this locale.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was tempted to restore locales here, but the page use languages, so let's keep that.

@flodolo flodolo left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to Pontoon!

For the future, please make sure to ask in the issue before opening PRs, because they might not be ready for implementation.

@flodolo
flodolo merged commit 0f0b118 into mozilla:main Sep 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obsolete link for Google Translate supported locales

2 participants