Batch actions: Add the ability to pretranslate strings by MundiaNderi · Pull Request #4455 · mozilla/pontoon

MundiaNderi · 2026-08-27T17:31:32Z

This is a draft pr because I want to context switch

Allows contributors to manually batch pretranslate strings for locales supported by translation engines.

codecov-commenter · 2026-08-27T17:33:26Z

Codecov Report

❌ Patch coverage is 76.80000% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.50%. Comparing base (4e07692) to head (b0bc75a).
⚠️ Report is 3 commits behind head on main.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

flodolo · 2026-08-27T17:37:00Z

I haven't looked at the code, but

Teams might want to benefit from pretranslation capabilities on projects for which pretranslation is not enabled (by the admins).

This should not be available to contributors. I would go as far as to limit this to members of the pretranslator group.

mathjazz · 2026-08-27T18:19:31Z

This should not be available to contributors. I would go as far as to limit this to members of the pretranslator group.

What do you mean by "pretranslator group"?

Batch actions in general are only available to translators.

flodolo · 2026-08-27T18:24:34Z

What do you mean by "pretranslator group"?

There is a pretranslators group used to gate access to the API.

Batch actions in general are only available to translators.

In this case, I don't think it should. We want visibility on which projects have pretranslation enabled, and check quality.

mathjazz · 2026-08-27T20:08:03Z

Could you elaborate in more detail a bit on how you envision that to work? How would I as a translator join the group?

In this case, I don't think it should. We want visibility on which projects have pretranslation enabled, and check quality.

Why is that not possible if pretranslation is available to translators or managers?

flodolo · 2026-08-28T01:02:31Z

Can we move this conversation to the issue?

How would I as a translator join the group?

They wouldn't, that's a manually curated group, because the associated API has a cost and can be abused.

Pretranslation is enabled on a locale+project base with strict criteria. Why would we suddenly change this, through batch actions of all places?
https://mozilla-l10n.github.io/localizer-documentation/tools/pretranslation.html#opt-in-guidelines

Why is that not possible if pretranslation is available to translators or managers?

Pretranslation is not available to translators or managers. Pretranslation is enabled on a project and locale, and by default will translate all resources in the project: what's the goal of having a batch action?

flodolo · 2026-09-16T12:46:59Z

@MundiaNderi
You mentioned you had errors locally. Could you add them?

flodolo · 2026-09-16T12:58:00Z

Looks like it was posted in the wrong PR? #4406 (comment)

ValueError at /batch-edit-translations/

A @fluent-fn attribute is required for :platform

Exception Location: /usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py, line 507, in function_ref

Traceback (most recent call last):
File "/usr/local/lib/python3.13/site-packages/django/core/handlers/exception.py", line 55, in inner
response = get_response(request)
File "/usr/local/lib/python3.13/site-packages/django/core/handlers/base.py", line 197, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/app/pontoon/batch/views.py", line 131, in batch_edit_translations
action_status = pretranslate_translations(user, locale, entities)
File "/app/pontoon/batch/actions.py", line 436, in pretranslate_translations
pretranslation = get_pretranslation(entity, locale)
File "/app/pontoon/pretranslation/pretranslate.py", line 85, in get_pretranslation
pt_res = pt.serialize(value, properties)
File "/app/pontoon/pretranslation/pretranslate.py", line 185, in serialize
return as_string(self.format, entry, fluent_escape_syntax=False)
File "/app/pontoon/sync/formats/init.py", line 62, in as_string
fluent_entry = fluent_astify_entry(
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 202, in fluent_astify_entry
value = fluent_astify_message(
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 312, in fluent_astify_message
selector = value(message.declarations, message.selectors[len(keys0) - 1])
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 528, in value
return expression(decl, decl[val.name], val.name)
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 444, in expression
return function_ref(decl, arg, expr)
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 507, in function_ref
raise ValueError(f"A @fluent-fn attribute is required for :{function}")

Exception Type: ValueError at /batch-edit-translations/
Exception Value: A @fluent-fn attribute is required for :platform

Can it be that you run the migration with an old version of moz-l10n, and that didn't fix existing strings with PLATFORM()?

See #4533 (comment)

MundiaNderi · 2026-09-16T14:16:10Z

Looks like it was posted in the wrong PR? #4406 (comment)

ValueError at /batch-edit-translations/

A @fluent-fn attribute is required for :platform

Exception Location: /usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py, line 507, in function_ref

Traceback (most recent call last):
File "/usr/local/lib/python3.13/site-packages/django/core/handlers/exception.py", line 55, in inner
response = get_response(request)
File "/usr/local/lib/python3.13/site-packages/django/core/handlers/base.py", line 197, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/app/pontoon/batch/views.py", line 131, in batch_edit_translations
action_status = pretranslate_translations(user, locale, entities)
File "/app/pontoon/batch/actions.py", line 436, in pretranslate_translations
pretranslation = get_pretranslation(entity, locale)
File "/app/pontoon/pretranslation/pretranslate.py", line 85, in get_pretranslation
pt_res = pt.serialize(value, properties)
File "/app/pontoon/pretranslation/pretranslate.py", line 185, in serialize
return as_string(self.format, entry, fluent_escape_syntax=False)
File "/app/pontoon/sync/formats/init.py", line 62, in as_string
fluent_entry = fluent_astify_entry(
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 202, in fluent_astify_entry
value = fluent_astify_message(
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 312, in fluent_astify_message
selector = value(message.declarations, message.selectors[len(keys0) - 1])
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 528, in value
return expression(decl, decl[val.name], val.name)
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 444, in expression
return function_ref(decl, arg, expr)
File "/usr/local/lib/python3.13/site-packages/moz/l10n/formats/fluent/serialize.py", line 507, in function_ref
raise ValueError(f"A @fluent-fn attribute is required for :{function}")

Exception Type: ValueError at /batch-edit-translations/
Exception Value: A @fluent-fn attribute is required for :platform

Can it be that you run the migration with an old version of moz-l10n, and that didn't fix existing strings with PLATFORM()?

See #4533 (comment)

Ah yes - the 'wrong PR' was what I had open during the meeting. I will look into the new issue and see if there's any correlation, then revert, possibly tomorrow evening / Friday.

Batch actions: Add the ability to pretranslate strings This is a draft pr because I want to context switch Allows contributors to manually batch pretranslate strings for locales supported by translation engines.

Fixes mozilla#2790

candidate fails to parse, rather than failing the whole batch. Mirrors the existing behavior in pretranslation/tasks.py

EditorMenu only renders when no entities are batch-selected, so requestInProgress === 'pretranslate' can never coincide with it being mounted. In-progress feedback already exists in Pretranslate.tsx.

pretranslation candidate or an unparsable one

flodolo

We have #4526 to align the background task with the API, but we should probably run bulk_run_checks() to avoid storing a pretranslation with warnings/errors.

flodolo · 2026-09-23T09:09:16Z

+    for which pretranslation is not enabled by the admins.
+    """
+
+    entity_pks_with_translation = set(


This is excluding approved translations, but it's going to pretranslate strings that already have a pretranslation. We should probably exclude those by filtering the authors (pt_authors = get_pretranslation_authors()).

That means also renaming this variable, e.g. excluded_entity_pks.

Again, flagging @mathjazz for an opinion. Since we want to change the behavior for the task, we might want to pretranslate strings with pending suggestions .filter(Q(approved=True) | Q(user__in=pt_authors.values())).

flodolo · 2026-09-23T09:10:51Z

+                fuzzy=False,
+                pretranslated=True,
+                active=entity.pk not in already_active_entity_pks,
+                user=user,


Waiting for @mathjazz opinion, but I think we shouldn't attribute this to the user running pretranslation, but to tm or gt, like we do when running pretranslation as a task. At that point, updating badge levels is unnecessary.

In case, the same applies later for the actionlog.

Removed the badge updates. Happy to revisit attributing pretranslation to tm/gt next week in a follow-up if @mathjazz thinks it's worth it.

MundiaNderi changed the title ~~Fixes #2790~~ Batch actions: Add the ability to pretranslate strings Aug 27, 2026

MundiaNderi self-assigned this Aug 27, 2026

MundiaNderi force-pushed the pretranslate-2790 branch from f335fbf to 9f335e9 Compare September 7, 2026 21:57

flodolo mentioned this pull request Sep 16, 2026

Fluent strings with SHORTDATE() reimported and showing up broken as {�} #4533

Closed

MundiaNderi force-pushed the pretranslate-2790 branch from 9f335e9 to fce5ee6 Compare September 22, 2026 15:51

MundiaNderi added 4 commits September 22, 2026 19:05

Fixes mozilla#2790

6cc6f12

Batch actions: Add the ability to pretranslate strings This is a draft pr because I want to context switch Allows contributors to manually batch pretranslate strings for locales supported by translation engines.

Restrict pretranslation to the pretranslators group

b8d22ff

Fixes mozilla#2790

Batch pretranslation now skips entities whose translation-memory/MT

ddd8a5d

candidate fails to parse, rather than failing the whole batch. Mirrors the existing behavior in pretranslation/tasks.py

Remove dead pretranslation-in-progress banner from EditorMenu

a1ea4ee

EditorMenu only renders when no entities are batch-selected, so requestInProgress === 'pretranslate' can never coincide with it being mounted. In-progress feedback already exists in Pretranslate.tsx.

MundiaNderi force-pushed the pretranslate-2790 branch from fce5ee6 to a1ea4ee Compare September 23, 2026 08:15

Keep track of invalid pretranslations skipped due to a missing

b0bc75a

pretranslation candidate or an unparsable one

MundiaNderi marked this pull request as ready for review September 23, 2026 08:47

MundiaNderi requested a review from mathjazz September 23, 2026 08:47

flodolo reviewed Sep 23, 2026

View reviewed changes

Conversation

MundiaNderi commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

flodolo commented Aug 27, 2026

Uh oh!

mathjazz commented Aug 27, 2026

Uh oh!

flodolo commented Aug 27, 2026

Uh oh!

mathjazz commented Aug 27, 2026

Uh oh!

flodolo commented Aug 28, 2026

Uh oh!

flodolo commented Sep 16, 2026

Uh oh!

flodolo commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MundiaNderi commented Sep 16, 2026

Uh oh!

flodolo left a comment

Choose a reason for hiding this comment

Uh oh!

flodolo Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

flodolo Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

MundiaNderi Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MundiaNderi commented Aug 27, 2026 •

edited

Loading

codecov-commenter commented Aug 27, 2026 •

edited

Loading

flodolo commented Sep 16, 2026 •

edited

Loading

MundiaNderi Sep 29, 2026 •

edited

Loading