Repository navigation
Conversation
dschom
marked this pull request as ready for review
September 15, 2026 02:33
vbudhram
approved these changes
Sep 15, 2026
Because: - Android App Links only verify against the real SHA-256 signing certificate fingerprints of Firefox Android. The route served a placeholder string. - Release and Beta share a signing certificate while Nightly uses a different one, so a single shared list cannot be correct. This commit: - Replaces the placeholder with fingerprints read via apksigner from the 155.0.1, 157.0b1 and 158.0a1 APKs on ftp.mozilla.org. - Maps fingerprints per package name instead of one shared list. - Formats fingerprints as upper-case colon-separated hex, the form Digital Asset Links requires. - Adds a Playwright smoke spec for the endpoint's shape and format. Closes FXA-14084
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
apksignerfrom the 155.0.1, 157.0b1 and 158.0a1 APKs on ftp.mozilla.org.packages/functional-tests/tests/misc.spec.tscovering the endpoint's status, package list, relation and fingerprint format.Issue that this pull request solves
Closes: FXA-14084
Checklist
Put an
xin the boxes that applyHow to review (Optional)
App Links cannot be exercised locally (see below). Verify on stage once this deploys:
Content-Type: application/json:android:autoVerify="true". If Fenix only declaresaccounts.firefox.com, stage will never verify and step 4 only works against prod.verified:Repeat with
org.mozilla.firefox_betaandorg.mozilla.fenixto cover the Beta and Nightly certificates.Screenshots (Optional)
Other information (Optional)
Why this cannot be tested on localhost: Android verifies App Links at app install or update time, not when a link is opened. The system verifier fetches
https://<host>/.well-known/assetlinks.jsonfor each host Fenix declares withautoVerify, https only, port 443 only, no redirects, and caches the result. A local server fails every one of those conditions,localhoston the phone is the phone itself, and Fenix does not declarelocalhostas a host. The QR code also encodes the current origin, so locally it is an http URL, and http URLs never participate in App Links. Scanning a local QR code will always open the default browser regardless of what this route serves.