Repository navigation
Conversation
…tions Because: - A plain /pair or /connect_another_device URL with no context builds a Web integration, so useFxAStatus never asked the browser. - Without the browser's pairingVersion, the page guessed and sent v2 browsers down the v1 pairing flow. This commit: - Adds isPairingEntryPathname and treats matching routes as pairing flows in useFxAStatus. - Passes location.pathname into useFxAStatus from AuthAndAccountSetupRoutes. - Adds tests for the Web integration pairing entry case and the pathname matcher.
dschom
changed the title
dschom
marked this pull request as ready for review
September 16, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
Web integration, so useFxAStatus never asked the browser.
browsers down the v1 pairing flow.
This pull request
flows in useFxAStatus.
AuthAndAccountSetupRoutes.
pathname matcher.
Issue that this pull request solves
Closes: FXA-14500
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Pretty easy to review. Just make sure v2 pairing is supported in fxa and desktop, and then go to
http://localhost:3030/pair. Before these changes we'd have seen the interstitial, now we see the V2 pairing code.Screenshots (Optional)
FXA-14500 — direct
/pairon Firefox Nightly withidentity.fxaccounts.pairing.version = 2Stack serving
pairing.version = 2, signed-in Nightly, plain/pairwith no query string.On
mainthe page never asks the browser forfxa_status, defaults to pairing v1, and shows the choice screen. On this branch it negotiates into/pair/authority/scan_qr(nov=2in the URL) and the QR renders.Other information (Optional)