Skip to content

fix(settings): wrap the scan-QR help link inside the phone frame - #21189

Merged
dschom merged 1 commit into
mainfrom
FXA-14486
Sep 18, 2026
Merged

dschom merged 1 commit into
mainfrom
FXA-14486

Conversation

@dschom

@dschom dschom commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Because

  • On the new pairing scan-QR page, long translations of the "Get help scanning" link (French, for one) overflow the phone graphic frame.

This pull request

  • Caps the help link's width so long strings wrap onto a second line inside the phone screen.

Issue that this pull request solves

Closes: FXA-14486

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

FXA-14486 — "Get help scanning" link, French, on /pair/authority/scan_qr

Storybook, Pages/Pair2/Authority/ScanQR, Firefox with locale fr. The local l10n bundle has no French for this key yet, so the link text is the string quoted in the ticket, placed into the link's text node. Link measures 220x42 px against the 46% cap of a 480 px card.

After (this branch) After, denser QR
After: French help link wraps inside the phone screen After: same, with a denser QR code

Other information (Optional)

  • The overlay does not grow the card, so a translation needing a third line would still clip below the artwork. The French string fits in two.

Because:
 - On /pair/authority/scan_qr the "Get help scanning" link had no width
   limit, so long translations such as French ran past the phone bezel.

This commit:
 - Caps the link at 46% of the artwork so long strings wrap onto a second
   line inside the phone screen.

Closes #FXA-14486
@dschom
dschom marked this pull request as ready for review September 17, 2026 22:21
@dschom
dschom requested a review from a team as a code owner September 17, 2026 22:21
@dschom
dschom merged commit d4d1db0 into main Sep 18, 2026
18 of 20 checks passed
@dschom
dschom deleted the FXA-14486 branch September 18, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants