Repository navigation
Let the user review add-on updates that need new permissions - #4634
Merged
jonalmeida merged 2 commits intoNov 5, 2026
Merged
Conversation
Android Components no longer posts a notification for these updates; it keeps them pending in the BrowserStore and AddonsManagerAdapter shows a banner whose buttons call these delegate methods.
|
Queue requested — the merge queue status continues in this comment ↓. |
✅ Merged into
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android Components (Bug 2067732) no longer posts a system notification for add-on updates that need new permissions. It keeps them in
BrowserState.pendingExtensionUpdates, andAddonsManagerAdaptershows a banner whose review and cancel buttons call newAddonsManagerAdapterDelegatemethods. Without implementations of those, such updates stay pending forever.This implements
onReviewExtensionUpdateClickedandonCancelExtensionUpdateClickedinAddonsFragment, following the AC sample browser. The update dialog uses its own fragment tag becauseWebExtensionPromptFeaturere-attaches its install-flow handlers to any permissions dialog under its tag.