Skip to content

Let the user review add-on updates that need new permissions - #4634

Merged
jonalmeida merged 2 commits into
mozilla-mobile:masterfrom
rvandermeulen:addon-update-review
Nov 5, 2026
Merged

jonalmeida merged 2 commits into
mozilla-mobile:masterfrom
rvandermeulen:addon-update-review

Conversation

@rvandermeulen

Copy link
Copy Markdown
Contributor

Android Components (Bug 2067732) no longer posts a system notification for add-on updates that need new permissions. It keeps them in BrowserState.pendingExtensionUpdates, and AddonsManagerAdapter shows a banner whose review and cancel buttons call new AddonsManagerAdapterDelegate methods. Without implementations of those, such updates stay pending forever.

This implements onReviewExtensionUpdateClicked and onCancelExtensionUpdateClicked in AddonsFragment, following the AC sample browser. The update dialog uses its own fragment tag because WebExtensionPromptFeature re-attaches its install-flow handlers to any permissions dialog under its tag.

Android Components no longer posts a notification for these updates; it keeps them pending in the BrowserStore
and AddonsManagerAdapter shows a banner whose buttons call these delegate methods.
@mergify

mergify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Queue requested — the merge queue status continues in this comment ↓.

@jonalmeida jonalmeida left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rvandermeulen rvandermeulen added the needs landing Auto lands approved and green PRs. label Nov 5, 2026
@mergify mergify Bot added the queued label Nov 5, 2026
@mergify

mergify Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

✅ Merged into master as 42687c4 at 18:40 UTC

10 min in the queue, 8 min of it CI.

So far

  • ✅ Entered the queue Thu 5 Nov, 18:30 · rule default · triggered by rule Needs landing - Merge
  • ✅ Passed · in place
  • ✅ Merged 18:40 · 42687c4 · rebase
1 merge condition met
  • status-success=pr-complete

Times in UTC · dashboard · how the merge queue works

@jonalmeida
jonalmeida merged commit 42687c4 into mozilla-mobile:master Nov 5, 2026
13 of 14 checks passed
@mergify mergify Bot removed the queued label Nov 5, 2026
@rvandermeulen
rvandermeulen deleted the addon-update-review branch November 5, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs landing Auto lands approved and green PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants