resolute: add explicit <cstdint> / <fstream> includes for GCC 15#3754
Open
nbbrooks wants to merge 1 commit into
Open
resolute: add explicit <cstdint> / <fstream> includes for GCC 15#3754nbbrooks wants to merge 1 commit into
nbbrooks wants to merge 1 commit into
Conversation
GCC 15 (default on Ubuntu Resolute) stopped transitively including <cstdint> and <ostream> through other standard headers. Any translation unit that uses uint8_t / int32_t / std::endl etc. without the explicit include can fail to compile. - Add <cstdint> to 21 files (headers + cpp) that use fixed-width integer types directly. Alphabetically ordered in each include block. - Add <fstream> to moveit_setup_simulation/src/simulation.cpp, which uses std::ofstream / std::endl with only a single project-header include. <fstream> transitively brings in <ostream>. This is speculative cleanup based on the GCC 15 porting guide and upstream ros2 reports of the same class of failure; the files compile fine under GCC 13 with the change since <cstdint> is a no-op when the type is already visible. Refs: - https://gcc.gnu.org/gcc-15/porting_to.html - moveit#3603 (boost::regex vs std::regex; same class of issue)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3754 +/- ##
==========================================
- Coverage 46.24% 46.23% -0.00%
==========================================
Files 726 726
Lines 59513 59512 -1
Branches 7623 7623
==========================================
- Hits 27516 27512 -4
- Misses 31831 31832 +1
- Partials 166 168 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 15 (default on Ubuntu Resolute) stopped transitively including and through other standard headers. Any translation unit that uses uint8_t / int32_t / std::endl etc. without the explicit include can fail to compile.
This is speculative cleanup based on the GCC 15 porting guide and upstream ros2 reports of the same class of failure; the files compile fine under GCC 13 with the change since is a no-op when the type is already visible.
Refs:
Description
Please explain the changes you made, including a reference to the related issue if applicable
Checklist