refactor: remove unused result-batches.ts and migrate manual formatting to Format singleton (@codewithyuvraj24)#8212
Open
codewithyuvraj24 wants to merge 2 commits into
Open
Conversation
fehmer
reviewed
Jul 9, 2026
Member
There was a problem hiding this comment.
this needs to be converted to solidjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Delete unused
result-batches.tsfrontend/src/ts/elements/result-batches.tswas not imported or referenced anywhere in the codebase.//TODO fix or delete?comment.2. Migrate manual formatting in
result.tsto useFormatsingleton//TODO: use Formatcomment at the top ofresult.ts..toFixed(2)andNumbers.roundTo2(...).toFixed(2)calls withFormat.decimals()for WPM, raw WPM, test duration, and personal best annotations.3. Clean up
route-controller.tsevent?.preventDefault()and its//todo: figure out if this was ever usedcomment. Thenavigatefunction has noeventparameter, so this was dead code.Verification
pnpm oxlint --type-aware --type-check— passed with 0 errors.pnpm dev-fe) — compiles and starts successfully.