Repository navigation
PYTHON-6163 Pure-Python decode_all silently accepts 1-byte invalid BSON - #3117
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Align the error message with the C implementation and add the required changelog entry.
2 open findings
What changed in this PR
Updates pure-Python decode_all to reject truncated BSON consistently with the C extension.
Changes:
- Adds BSON size and boundary validation.
- Adds regression tests for partial buffers and supported buffer types.
| File | Summary |
|---|---|
bson/__init__.py |
Adds pure-Python BSON size validation. |
test/test_bson.py |
Adds truncated-document regression coverage. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PYTHON-6163
Changes in this PR
The pure-Python decoder silently accepted buffers ending in a partial document, while the C extension raises InvalidBSON. The Python version now applies the same checks and messages.
Test Plan
Checklist
Checklist for Author
Checklist for Reviewer