Repository navigation
PYTHON-6149 Fix condition for minPoolSize validation - #3099
Conversation
|
Thanks @MaddipatlaChetan24 ! Can you please add a test and changelog entry? |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Assigned |
|
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
PYTHON-6149
Changes in this PR
_parse_pool_optionsonly exemptedmaxPoolSize=Nonefrom theminPoolSize <= maxPoolSizecheck. The docs say both0andNonemean no limit, and the pool treats both as unlimited. This madeMongoClient(maxPoolSize=0, minPoolSize=5)raiseValueErrorwhilemaxPoolSize=Nonewas accepted.0andNone.Test Plan
maxPoolSize=0andmaxPoolSize=None, each withminPoolSize=5: accepted.maxPoolSize=10, minPoolSize=20, andminPoolSize=200against the default max of 100: still raiseValueError.maxPoolSize=10, minPoolSize=10: still accepted.Checklist
Checklist for Author
Checklist for Reviewer