Repository navigation
CSHARP-6246: Test that srvAllowedHostsSuffix accepts an underscore - #2169
Merged
Merged
Conversation
adelinowona
added
the
chore
adelinowona
marked this pull request as ready for review
October 27, 2026 14:47
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test additions follow existing patterns, cover the intended behavior, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
This test-only PR adds regression coverage confirming that the MongoDB C# driver's srvAllowedHostsSuffix accepts underscores.
Changes:
- Adds a DNS seedlist discovery test that resolves a host matching an underscore-containing suffix.
- Adds a normalization test case confirming that
.my_domain.netis preserved.
| File | Description |
|---|---|
| tests/MongoDB.Driver.Tests/Specifications/initial-dns-seedlist-discovery/prose-tests/SrvPartsTests.cs | Tests SRV resolution with an underscore-containing allowed suffix. |
| tests/MongoDB.Driver.Tests/Core/Configuration/ConnectionStringTests.cs | Tests normalization of an underscore-containing suffix. |
Review effort: Balanced
papafe
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.