Skip to content

fix: handle cancellation for request ID 0 #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pshah19 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: handle cancellation for request ID 0 #2654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core-internal/src/shared/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,7 @@ export abstract class Protocol<ContextT extends BaseContext> {
}

private async _oncancel(notification: CancelledNotification): Promise<void> {
if (!notification.params.requestId) {
if (notification.params.requestId === undefined) {
return;
}
// Handle request cancellation
Expand Down
4 changes: 2 additions & 2 deletions packages/core-internal/test/shared/protocol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ describe('protocol tests', () => {
});

describe('notifications/cancelled behavior', () => {
test('should abort request handler when notifications/cancelled is received', async () => {
test('should abort request handler when notifications/cancelled contains requestId 0', async () => {
await protocol.connect(transport);

// Set up a request handler that checks if it was aborted
Expand All @@ -788,7 +788,7 @@ describe('protocol tests', () => {
});

// Simulate an incoming request
const requestId = 123;
const requestId = 0;
if (transport.onmessage) {
transport.onmessage({
jsonrpc: '2.0',
Expand Down
Loading