ENH: Add public LayeredMesh and brain.layered_meshes#13970
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
…data overlays [circle linkcheck]
for more information, see https://pre-commit.ci
|
Oh and I forgot to add... we'll want some updated tests. It looks like some are already failing, see for example Which suggests you need to make things private or add docstrings. I think Then you'll want to modify an existing test to make use of the basics of the API. I'd take some existing test in Typically we also want to showcase this functionality in an updated example... but this is niche enough that I think it's not 100% needed here. You could update something in the Brain example if you were motivated though! |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
for more information, see https://pre-commit.ci
…e, LayeredMesh test and brain example
for more information, see https://pre-commit.ci
larsoner
left a comment
There was a problem hiding this comment.
I'll push the suggestion then merge once the example renders and looks okay. Thanks in advance @payamsash !
|
Rendered better this time so marking for merge-when-green, thanks in advance @payamsash ! |
Reference issue (if any)
#13949
What does this implement/fix?
Adds the streaming API discussed in the issue:
_LayeredMeshchanged toLayeredMesh(public, with_LayeredMeshalias kept for compat)LayeredMesh.smooth_mat: sparse matrix applied automatically inadd_overlay/update_overlayBrain.add_data(key="data"): named overlaysBrain.layered_meshes: access the mesh dict directlyset_data_smoothing()now syncssmooth_matonto the meshLayeredMeshexported frommne.vizAdditional information