Add Debian/Ubuntu preflight dependency check for build-shotcut.sh - #1870
Add Debian/Ubuntu preflight dependency check for build-shotcut.sh#1870Proggerdogger wants to merge 1 commit into
Conversation
Detect missing host build tools before a long compile and print one sorted sudo apt install command. Disable with ACTION_PREFLIGHT=0.
|
This is not a change I want to include because |
|
I can accept the new script and mention it in the readme. |
|
Sounds good. I can understand you not wanting to maintain a new script when it's not generally useful. Putting it in the readme means someone can make the install easier if they want to. It'll be interesting to see if anyone uses it. |
|
Rejected because this script is used for CI including macOS. Also, it only works with Debian-derived distributions. People developing on Linux should use a distro that has the latest release of MLT (rolling, unstable, etc.) and simply use the hard, direct dependencies mentioned in the README. |
Summary
scripts/build-shotcut.shcan fail late in a long build when a host tool is missing. This addsscripts/preflight-deps.shfor Debian/Ubuntu-family systems to report all missing packages in one sortedsudo apt installcommand, and runs it early frombuild-shotcut.shby default.1aborts the build with the install hint2(unsupported OS) warns and continuesACTION_PREFLIGHT=0inbuild-shotcut.confaptTest plan
scripts/preflight-deps.shexits 0 on a stock Debian/Ubuntu build host with deps presentPATH, exits 1 and prints one sortedsudo apt install -y …lineACTION_PREFLIGHT=0skips the check