Skip to content

[Flags] Clarify behavior around fallback values - #219

Merged
matthewestopinal merged 7 commits into
mainfrom
mestopinal-feature-flags-fallback-clarification
Sep 10, 2026
Merged

[Flags] Clarify behavior around fallback values#219
matthewestopinal merged 7 commits into
mainfrom
mestopinal-feature-flags-fallback-clarification

Conversation

@matthewestopinal

Copy link
Copy Markdown
Contributor

No description provided.

@matthewestopinal
matthewestopinal requested a review from a team as a code owner September 1, 2026 21:48
@mintlify

mintlify Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
mixpanel-docs 🟢 Ready View Preview Sep 10, 2026, 3:55 PM

@devinfra-gh-app
devinfra-gh-app Bot requested a review from efahk September 1, 2026 21:48
@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR is not yet safe to merge because the fallback definition still conflicts with documented sticky-assignment behavior.

Findings

  1. P1 Fallback ignores retained assignments

Reviews (7) · Last reviewed commit: "Merge branch 'main' into mestopinal-feat..."

Comment thread docs/featureflags.mdx
Comment thread docs/featureflags.mdx Outdated
Comment thread docs/featureflags.mdx Outdated
Co-authored-by: efahk <37164746+efahk@users.noreply.github.com>
Comment thread docs/featureflags.mdx Outdated

@russell-loube-mixpanel russell-loube-mixpanel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nits

Comment thread docs/featureflags.mdx Outdated
Comment thread docs/featureflags.mdx Outdated
Comment thread docs/featureflags.mdx
- **Variants** — experience labels (e.g., `control`, `A`, `B`).
- **Variant Splits** — allocation across variants (e.g., 90%/10%).
- **Fallback Value** — variant to use when an assignment is unavailable.
- **Fallback Value** — the value your app supplies at call time (e.g., to `get_variant_value`) that is used whenever the SDK does not return an assignment. Treat this as the default, control experience for your rollout that's served to a user who has not received an assignment. Reasons may include the user being outside the rollout %, excluded by targeting filters, not having a persisted sticky variant or client-side assignment, or feature flag API call failure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Fallback ignores retained assignments

When a previously assigned user is later excluded by a rollout-percentage or targeting change, a sticky or persisted client-side assignment can continue serving the prior variant, while this definition presents those exclusions as reasons the fallback is served. Developers can therefore expect the default experience while affected users continue receiving their previous variant.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@matthewestopinal
matthewestopinal merged commit b546bc2 into main Sep 10, 2026
6 checks passed
@matthewestopinal
matthewestopinal deleted the mestopinal-feature-flags-fallback-clarification branch September 10, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants