Repository navigation
Validate the catalogue once in configure - #56
Merged
thomas-samoht merged 1 commit intoNov 10, 2026
Merged
Conversation
ricklambrechts
previously approved these changes
Nov 9, 2026
thomas-samoht
force-pushed
the
fix/validate-catalogue-once
branch
from
November 9, 2026 15:57
56d8425 to
2f3bdd8
Compare
thomas-samoht
changed the base branch from
main
to
fix/access-status-500-on-crash
November 9, 2026 15:57
ricklambrechts
previously approved these changes
Nov 9, 2026
thomas-samoht
dismissed
ricklambrechts’s stale review
November 10, 2026 08:51
The merge-base changed after approval.
thomas-samoht
force-pushed
the
fix/validate-catalogue-once
branch
2 times, most recently
from
November 10, 2026 09:05
e9c8f3c to
1857ec6
Compare
Problem: configure() called validate_catalogue() itself, then called register_catalogue(), which validates the same catalogue again before storing it. Every boot walked the catalogue twice, and the two calls had to be kept in step with the same access_logs argument. Fix: configure() registers the catalogue first and relies on register_catalogue() to validate it. That call validates before it stores anything, so an invalid catalogue still fails before any other setting is registered, as it did when the separate call came first. Tests check that configure() validates once and that an invalid catalogue leaves the catalogue and the access logs setting unregistered.
thomas-samoht
force-pushed
the
fix/validate-catalogue-once
branch
from
November 10, 2026 09:24
1857ec6 to
1e0d0ae
Compare
ricklambrechts
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.