Skip to content

Validate the catalogue once in configure - #56

Merged
thomas-samoht merged 1 commit into
fix/access-status-500-on-crashfrom
fix/validate-catalogue-once
Nov 10, 2026
Merged

thomas-samoht merged 1 commit into
fix/access-status-500-on-crashfrom
fix/validate-catalogue-once

Conversation

@thomas-samoht

Copy link
Copy Markdown
Contributor

No description provided.

@thomas-samoht
thomas-samoht requested a review from a team as a code owner November 5, 2026 09:49
ricklambrechts
ricklambrechts previously approved these changes Nov 9, 2026
@thomas-samoht
thomas-samoht force-pushed the fix/validate-catalogue-once branch from 56d8425 to 2f3bdd8 Compare November 9, 2026 15:57
@thomas-samoht
thomas-samoht changed the base branch from main to fix/access-status-500-on-crash November 9, 2026 15:57
@thomas-samoht
thomas-samoht added this pull request to stack #61 November 9, 2026 15:57
ricklambrechts
ricklambrechts previously approved these changes Nov 9, 2026
@thomas-samoht
thomas-samoht dismissed ricklambrechts’s stale review November 10, 2026 08:51

The merge-base changed after approval.

@thomas-samoht
thomas-samoht force-pushed the fix/validate-catalogue-once branch 2 times, most recently from e9c8f3c to 1857ec6 Compare November 10, 2026 09:05
Problem: configure() called validate_catalogue() itself, then called
register_catalogue(), which validates the same catalogue again before
storing it. Every boot walked the catalogue twice, and the two calls
had to be kept in step with the same access_logs argument.

Fix: configure() registers the catalogue first and relies on
register_catalogue() to validate it. That call validates before it
stores anything, so an invalid catalogue still fails before any other
setting is registered, as it did when the separate call came first.
Tests check that configure() validates once and that an invalid
catalogue leaves the catalogue and the access logs setting unregistered.
@thomas-samoht
thomas-samoht force-pushed the fix/validate-catalogue-once branch from 1857ec6 to 1e0d0ae Compare November 10, 2026 09:24
@thomas-samoht
thomas-samoht merged commit dcdbfef into main Nov 10, 2026
15 of 26 checks passed
@thomas-samoht
thomas-samoht deleted the fix/validate-catalogue-once branch November 10, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants