Repository navigation
Replace update_context with set_context - #54
Merged
thomas-samoht merged 4 commits intoNov 10, 2026
Merged
Conversation
thomas-samoht
marked this pull request as ready for review
November 5, 2026 09:06
thomas-samoht
force-pushed
the
feat/replace-update-context-with-set-context
branch
from
November 9, 2026 15:57
e0a79f7 to
f9f8138
Compare
thomas-samoht
changed the base branch from
main
to
feat/log-unhandled-thread-exceptions
November 9, 2026 15:57
thomas-samoht
force-pushed
the
feat/replace-update-context-with-set-context
branch
7 times, most recently
from
November 10, 2026 09:16
d48f154 to
0919386
Compare
Base automatically changed from
feat/log-unhandled-thread-exceptions
to
main
November 10, 2026 09:19
thomas-samoht
force-pushed
the
feat/replace-update-context-with-set-context
branch
from
November 10, 2026 09:19
0919386 to
5137844
Compare
ricklambrechts
approved these changes
Nov 10, 2026
thomas-samoht
deleted the
feat/replace-update-context-with-set-context
branch
November 10, 2026 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_contextends with its block, so a value added from a dependency never reached the access record, the 500 record, or the records of refused and invalid requests.set_context()adds values for the rest of the request, so they reach those records too. It refuses the fields the middleware sets, refuses undeclared fields withstrict_fieldson, and does nothing where no context is bound.update_contextis removed. In a dependency, replacewith update_context(values): yieldwithset_context(values).set_strict_fieldsmoved togfmodules.logging.strictand is still exported fromgfmodules.logging.