Skip to content

Port "Add support for import defer proposal" - #1826

Merged
Jake Bailey (jakebailey) merged 7 commits into
microsoft:mainfrom
Andarist:port/import-defer
Oct 6, 2025
Merged

Port "Add support for import defer proposal" #1826
Jake Bailey (jakebailey) merged 7 commits into
microsoft:mainfrom
Andarist:port/import-defer

Conversation

@Andarist

@Andarist Mateusz Burzyński (Andarist) commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

@Andarist @nicolo-ribaudo
Port "Add support for import defer proposal"
4965550 
Co-authored-by: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= <hello@nicr.dev>
@Andarist @nicolo-ribaudo
Port "Restore import defer = parsing"
f246bba 
Co-authored-by: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= <hello@nicr.dev>
@Andarist
skip defer in dts emit
d4cf3f9
@Andarist
public api tweaks
2c010fc
jakebailey
Jake Bailey (jakebailey) reviewed Oct 5, 2025
View reviewed changes
Comment thread internal/ast/kind.go
Comment thread internal/ast/utilities.go Outdated
Comment thread internal/ls/autoimportfixes.go Outdated
Comment thread internal/parser/parser.go Outdated
Comment thread _packages/api/src/node.ts
jakebailey
Jake Bailey (jakebailey) requested changes Oct 6, 2025
View reviewed changes

@jakebailey Jake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as needing changes; the AST interfaces in the JS ast package need to be updated too.

@Andarist

Mateusz Burzyński (Andarist) commented Oct 6, 2025

Copy link
Copy Markdown
Contributor Author

Jake Bailey (@jakebailey) I pushed out a change but I'm not sure if this has to match Strada 100% or if this package can make minor breaking changes. Notably:

  • I removed ImportClause['isTypeOnly'] (Strada has it as deprecated)
  • I made ImportClause['phaseModifier'] required and the lack of the phase modifier is represented by SyntaxKind.Unknown. In Strada undefined would be used instead

@jakebailey

Jake Bailey (jakebailey) commented Oct 6, 2025

Copy link
Copy Markdown
Member

Looks correct to me. It's just a prototype so okay to make changes like this, and it won't be the final version anyway.

@jakebailey
Jake Bailey (jakebailey) added this pull request to the merge queue Oct 6, 2025
Merged via the queue into microsoft:main with commit ffc34e9 Oct 6, 2025
22 checks passed
Nathan Whitaker (nathanwhit) added a commit to denoland/typescript-go that referenced this pull request Oct 6, 2025
@nathanwhit @Andarist
@MichalMarsalek @jakebailey @HansBrende @a-tarasyuk @eps1lon @magic-akari @Renegade334 @ChiriVulpes @Zzzen @dyxushuai @nicolo-ribaudo @dependabot
Sync changes from upstream (#3)
4360e41 
* Port "Infer from annotated return type nodes before assigning contextual parameter types" (microsoft#1804)

* Port "make exported destructured discriminated union narrowing work" (microsoft#1806)

Co-authored-by: =?UTF-8?q?Michal=20Mar=C5=A1=C3=A1lek?= <MichalMarsalek@users.noreply.github.com>

* Implement more of doc highlights / find all refs (microsoft#1796)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* Port "Provide string completions for `in` keyword checks" (microsoft#1803)

* Port "Fix #61098" (microsoft#1810)

Co-authored-by: Hans Brende <firedrake93@gmail.com>

* Port "fix(61258): Renaming namespace with const enum doesn't update enum references" (microsoft#1811)

Co-authored-by: "Oleksandr T." <oleksandr.tarasiuk@outlook.com>

* Update dependencies (microsoft#1785)

* Mark libReplacement default as false (microsoft#1812)

* Port "Deemphasize old JSX transform" (microsoft#1809)

Co-authored-by: "Sebastian \"Sebbie\" Silbermann" <sebastian.silbermann@vercel.com>

* Port "fix(checker): report error when using bigint as enum key" (microsoft#1814)

Co-authored-by: magic-akari <akari.ccino@gmail.com>

* Port "explicitly disallow `using` in ambient contexts" (microsoft#1815)

Co-authored-by: =?UTF-8?q?Ren=C3=A9?= <contact.9a5d6388@renegade334.me.uk>

* Port 'Issue "'{0}' declarations can only be declared inside a block." for block-scoped variables in presence of parse errors' (microsoft#1816)

* Port "Avoid resolving source prop type when the target is `unknown`/`any`" (microsoft#1817)

* Port "Allow trailing commas after import attributes in `ImportType`" (microsoft#1818)

* Port "Fix BigInt literal error in ambient contexts when targeting < ES2020" (microsoft#1819)

* Port "Stop reassigning `.valueDeclaration` to avoid replacing earlier declarations with late ones" (microsoft#1813)

* Port "Keep accessors as accessors in emitted anonymous class declarations" (microsoft#1822)

* Port "Fixed crash in `hasVisibleDeclarations` related to binding elements" (microsoft#1820)

* Port "Properly disallow `yield` in bodyless arrows" (microsoft#1825)

* Port "Account for right operands & fix a weird error message for leftmost nullish literals in checkNullishCoalesceOperands" (microsoft#1805)

Co-authored-by: Chiri Vulpes <github@chiri.works>

* Remove JSDoc handling from the binder (microsoft#1827)

* Port "`arguments` should not be allowed in class static block" (microsoft#1828)

Co-authored-by: Zzzen <callmetsing@gmail.com>

* Port "check usage before declaration for decorators" (microsoft#1829)

Co-authored-by: Zzzen <callmetsing@gmail.com>

* Fix nil pointer dereference in snapshotFS.GetFile for non-existent files (microsoft#1830)

* Fix translation bug causing `unknown` infer-extends constraint to be emitted (microsoft#1831)

* Port "Fixed nullish coalesce operator's precedence" (microsoft#1824)

* Fixed an issue with type params being renamed incorrectly (microsoft#1833)

* Port "Add support for `import defer` proposal"  (microsoft#1826)

Co-authored-by: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= <hello@nicr.dev>

* Bump github/codeql-action from 3.30.5 to 3.30.6 in the github-actions group across 1 directory (microsoft#1832)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Port "Preserve type parameter constraint in emitted mapped types while preserving their distributivity" (microsoft#1834)

* disable create-cache ci job

* merge fixup

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-authored-by: =?UTF-8?q?Michal=20Mar=C5=A1=C3=A1lek?= <MichalMarsalek@users.noreply.github.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Hans Brende <firedrake93@gmail.com>
Co-authored-by: "Oleksandr T." <oleksandr.tarasiuk@outlook.com>
Co-authored-by: "Sebastian \"Sebbie\" Silbermann" <sebastian.silbermann@vercel.com>
Co-authored-by: magic-akari <akari.ccino@gmail.com>
Co-authored-by: =?UTF-8?q?Ren=C3=A9?= <contact.9a5d6388@renegade334.me.uk>
Co-authored-by: Chiri Vulpes <github@chiri.works>
Co-authored-by: Zzzen <callmetsing@gmail.com>
Co-authored-by: John Xu <dyxushuai@gmail.com>
Co-authored-by: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= <hello@nicr.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@chenjiahan Jiahan Chen (chenjiahan) mentioned this pull request Nov 3, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakebailey Jake Bailey (jakebailey) jakebailey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Andarist @jakebailey