Repository navigation
Add service group support to Advisor recommendation summaries - #3799
Merged
Vinay Gera (g2vinay) merged 4 commits intoSep 30, 2026
Merged
Vinay Gera (g2vinay) merged 4 commits into
Vinay Gera (g2vinay) merged 4 commits into
Conversation
Ravi Gupta (ravigupta99)
requested review from
KarishmaGhiya,
Alan Zimmer (alzimmermsft),
Connie Yau (conniey),
Sai Koumudi Kaluvakolanu (saikoumudi),
Sandeep Sen (sandeep-sen),
Tom Meschter (tmeschter) and
Jeff Fisher (xirzec)
and removed request for
a team
September 29, 2026 06:55
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
17 of 19 tasks
Vinay Gera (g2vinay)
approved these changes
Sep 30, 2026
Vinay Gera (g2vinay)
added a commit
that referenced
this pull request
Oct 14, 2026
* Extend Advisor recommendation update to service groups (#3798) * Add service group support to Advisor recommendation summaries (#3799) * Extend Advisor recommendation list to service groups (#3691) * Extend Advisor recommendation list to service groups * Replace --mode enum with --prioritized boolean for Advisor recommendation list * Updated descriptions, added new e2e tests and simplified scope validation * refactor(advisor): join recommendation metadata in Resource Graph query Move metadata enrichment and prioritized ranking server-side, simplify client processing, and update query tests. * docs: expand Advisor recommendation list E2E prompts * fix(advisor): align list prioritization and truncation * Retain instance\-specific values for Personalized/Review recommendations * Refine recommendation ranking and result truncation * docs(advisor): clarify prioritized recommendation ordering Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Koushik B <koushikb@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix Speech endpoint placeholder link Render the example endpoint as inline code so Markdown link verification does not treat the placeholder host as a live URL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Ravi Gupta <44098228+ravigupta99@users.noreply.github.com> Co-authored-by: Koushik <50052906+koushik137@users.noreply.github.com> Co-authored-by: Koushik B <koushikb@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends the existing
advisor recommendation summarytool so the same MCP tool can summarize either subscription-scoped or Azure service-group-scoped Advisor recommendations.This PR targets
devbecausemainis under code freeze. The Azure MCP team will handle the subsequent uplift fromdevtomain.The unified summary tool:
--subscriptionor--service-groupand rejects requests that explicitly provide both.--resource-groupwith service-group scope instead of silently ignoring an ambiguous filter.properties.serviceGroupId =~ "/providers/Microsoft.Management/serviceGroups/{serviceGroup}".isempty(properties.serviceGroupId)population.{ key, label, count }response contract.serviceGroupIdto the shared recommendation properties model for update and future list reuse.The change also extracts the subscription-or-service-group binding and validation introduced by #3798 into
RecommendationScopeCommand<TOptions, TResult>. Both update and summary now share explicit option-presence handling, default-subscription resolution, mutual exclusion, and service-group ID validation. The merged update tool's behavior remains unchanged.Branch and dependency status
dev.main.upstream/devcommit containing Extend Advisor recommendation update to service groups #3798.Validation completed against latest
devazmcp.exeand independent tenant-scoped ARG validation: 23/23 passed.contoso-storefront: 3,665 total / 2,291 active recommendations.commerce: 3,664 total / 2,288 active recommendations.payment-processing-contoso-financial-services: 3,535 total / 2,218 active recommendations.commercepopulation spans two subscriptions.0.424563–0.600615.Build-Local.ps1 -VerifyNpxpassed; all server publishes, npm packaging, cache cleanup, and Azure/Fabric/Template npm tool-list invocations completed without inner command failures.Build-Local.ps1 -IncludeNative. The inner Azure MCP native publish remains blocked by the existing CosmosMicrosoft.Azure.Documents.JsonSerializableIL2026/IL3050/MSB3077 diagnostics; no Advisor-specific NativeAOT diagnostic was reported.3.0.0-beta.48output.Public references
GitHub issue number?
Follow-up to #3520. The update prerequisite was delivered to
devthrough #3798. Supersedes #3604.Azure DevOps PBI: https://dev.azure.com/msazure/One/_workitems/edit/39592401
Pre-merge Checklist
advisor_recommendation_summary; update changes are a behavior-preserving shared refactorservers/Azure.Mcp.Server/README.mdProcess-PackageReadMe.ps10.4with top-three ranking for every summary promptconsolidated-tools.jsonservers/Azure.Mcp.Server/docs/azmcp-commands.mdUpdate-AzCommandsMetadata.ps1servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdusing current escaped-input conventionsInvoking Livetests
Copilot submitted PRs are not trustworthy by default. Users with
writeaccess to the repo need to validate the contents of this PR before leaving a comment with the text/azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.