Skip to content

MCP Tools in Drills: Drill Delete - #3343

Merged
Vinay Gera (g2vinay) merged 9 commits into
mainfrom
users/dhruvbharuka/drilldelete
Aug 25, 2026
Merged

MCP Tools in Drills: Drill Delete #3343
Vinay Gera (g2vinay) merged 9 commits into
mainfrom
users/dhruvbharuka/drilldelete

Conversation

@dynamicdhx

Copy link
Copy Markdown
Contributor

What does this PR do?

[Provide a clear, concise description of the changes]

[Add additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@dynamicdhx

Copy link
Copy Markdown
Contributor Author

Tool Description Evaluator Results

Test 1

Expected Tool: resilience_drill_delete
Prompt: Delete resilience drill <drill_name> from service group <service_group>

Results

Rank Score Tool Status
1 0.739009 resilience_drill_delete EXPECTED
2 0.657015 resilience_drill_get
3 0.559100 resilience_drill_resource_get
4 0.485199 resilience_recovery_plan_get
5 0.444589 resilience_goal_assignment_get

Test 2

Expected Tool: resilience_drill_delete
Prompt: Permanently remove drill <drill_name> in service group <service_group>

Results

Rank Score Tool Status
1 0.635281 resilience_drill_delete EXPECTED
2 0.464578 resilience_drill_get
3 0.461444 storagesync_syncgroup_delete
4 0.414723 sreagent_commonprompts_delete
5 0.410577 resilience_drill_resource_get

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new destructive MCP tool/CLI command for Azure Resilience Management to delete a resilience drill from a service group, wiring it through the toolset, server consolidation metadata, docs, and tests.

Changes:

  • Added resilience_drill_delete command (+ options + service API) and registered it in the Resilience Management toolset.
  • Added unit + live/recorded integration test coverage for drill deletion and updated test recordings tag.
  • Updated Azure MCP Server metadata and docs (consolidated tools, e2e prompts, azmcp command reference) and added a changelog entry.

Invoking Livetests

Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/ResilienceManagementCommandTests.cs Adds a live/recorded integration test invoking resilience_drill_delete.
tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/Drills/DrillDeleteCommandTests.cs Adds unit tests for validation, success, and error-handling behaviors of the delete command.
tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/assets.json Updates the assets tag for recorded test artifacts.
tools/Azure.Mcp.Tools.ResilienceManagement/src/Services/ResilienceManagementService.cs Implements DeleteDrillAsync using the ARM resource delete operation.
tools/Azure.Mcp.Tools.ResilienceManagement/src/Services/IResilienceManagementService.cs Adds the DeleteDrillAsync service contract.
tools/Azure.Mcp.Tools.ResilienceManagement/src/ResilienceManagementSetup.cs Registers DrillDeleteCommand and updates the drill subgroup description.
tools/Azure.Mcp.Tools.ResilienceManagement/src/Options/Drills/DrillDeleteOption.cs Introduces options for drill deletion (service group, drill, tenant, retry).
tools/Azure.Mcp.Tools.ResilienceManagement/src/Commands/ResilienceManagementJsonContext.cs Registers the delete result model for AOT-safe source-gen serialization.
tools/Azure.Mcp.Tools.ResilienceManagement/src/Commands/Drills/DrillDeleteCommand.cs Adds the new destructive command implementation + validation + error mapping.
servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json Adds consolidated tool mapping for resilience_drill_delete.
servers/Azure.Mcp.Server/docs/e2eTestPrompts.md Adds e2e prompts for resilience_drill_delete.
servers/Azure.Mcp.Server/docs/azmcp-commands.md Documents azmcp resilience drill delete.
servers/Azure.Mcp.Server/changelog-entries/dhruvbharuka-resilience-drill-delete.yml Adds a changelog entry announcing the new delete command.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread servers/Azure.Mcp.Server/docs/e2eTestPrompts.md Outdated
Comment thread servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json
…drilldelete

# Conflicts:
#	servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
#	tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/assets.json
#	tools/Azure.Mcp.Tools.ResilienceManagement/tests/test-resources-post.ps1
…icrosoft/mcp into users/dhruvbharuka/drilldelete

# Conflicts:
#	tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/assets.json
#	tools/Azure.Mcp.Tools.ResilienceManagement/tests/test-resources-post.ps1
@g2vinay
Vinay Gera (g2vinay) merged commit 35089f4 into main Aug 25, 2026
17 of 18 checks passed
@g2vinay
Vinay Gera (g2vinay) deleted the users/dhruvbharuka/drilldelete branch August 25, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants