MCP Tools in Drills: Drill Delete - #3343
Conversation
Tool Description Evaluator ResultsTest 1Expected Tool: Results
Test 2Expected Tool: Results
|
There was a problem hiding this comment.
Pull request overview
Adds a new destructive MCP tool/CLI command for Azure Resilience Management to delete a resilience drill from a service group, wiring it through the toolset, server consolidation metadata, docs, and tests.
Changes:
- Added
resilience_drill_deletecommand (+ options + service API) and registered it in the Resilience Management toolset. - Added unit + live/recorded integration test coverage for drill deletion and updated test recordings tag.
- Updated Azure MCP Server metadata and docs (consolidated tools, e2e prompts, azmcp command reference) and added a changelog entry.
Invoking Livetests
Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/ResilienceManagementCommandTests.cs | Adds a live/recorded integration test invoking resilience_drill_delete. |
| tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/Drills/DrillDeleteCommandTests.cs | Adds unit tests for validation, success, and error-handling behaviors of the delete command. |
| tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/assets.json | Updates the assets tag for recorded test artifacts. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Services/ResilienceManagementService.cs | Implements DeleteDrillAsync using the ARM resource delete operation. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Services/IResilienceManagementService.cs | Adds the DeleteDrillAsync service contract. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/ResilienceManagementSetup.cs | Registers DrillDeleteCommand and updates the drill subgroup description. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Options/Drills/DrillDeleteOption.cs | Introduces options for drill deletion (service group, drill, tenant, retry). |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Commands/ResilienceManagementJsonContext.cs | Registers the delete result model for AOT-safe source-gen serialization. |
| tools/Azure.Mcp.Tools.ResilienceManagement/src/Commands/Drills/DrillDeleteCommand.cs | Adds the new destructive command implementation + validation + error mapping. |
| servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json | Adds consolidated tool mapping for resilience_drill_delete. |
| servers/Azure.Mcp.Server/docs/e2eTestPrompts.md | Adds e2e prompts for resilience_drill_delete. |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Documents azmcp resilience drill delete. |
| servers/Azure.Mcp.Server/changelog-entries/dhruvbharuka-resilience-drill-delete.yml | Adds a changelog entry announcing the new delete command. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…icrosoft/mcp into users/dhruvbharuka/drilldelete
…drilldelete # Conflicts: # servers/Azure.Mcp.Server/docs/e2eTestPrompts.md # tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/assets.json # tools/Azure.Mcp.Tools.ResilienceManagement/tests/test-resources-post.ps1
…icrosoft/mcp into users/dhruvbharuka/drilldelete # Conflicts: # tools/Azure.Mcp.Tools.ResilienceManagement/tests/Azure.Mcp.Tools.ResilienceManagement.Tests/assets.json # tools/Azure.Mcp.Tools.ResilienceManagement/tests/test-resources-post.ps1
What does this PR do?
[Provide a clear, concise description of the changes][Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline