Repository navigation
.NET: [BREAKING] Ensure enable file hooks defaults to false - #10121
westey (westey-m) merged 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change to disable file hooks by default while preserving explicit caller settings.
No open issues 🎉
What changed in this PR
Updates the .NET GitHub Copilot agent integration so file hooks default to disabled for new and resumed sessions, while preserving explicit caller settings.
Changes:
- Centralizes new-session defaults through
CopySessionConfig, including null configurations. - Defaults unset
EnableFileHookstofalsewithout changing the streaming default. - Adds tests for null, unset, and explicitly enabled or disabled file-hook settings.
| File | Description |
|---|---|
dotnet/tests/Microsoft.Agents.AI.GitHub.Copilot.UnitTests/GitHubCopilotAgentTests.cs |
Tests file-hook defaults and preservation of explicit settings. |
dotnet/src/Microsoft.Agents.AI.GitHub.Copilot/GitHubCopilotAgent.cs |
Applies disabled file-hook defaults to session creation and resumption; updates helper documentation. |
Review effort: Balanced
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): b39700dfc98b
Model: gpt-5.6-sol
Overview
The PR explicitly defaults GitHub Copilot file hooks to disabled for both new and resumed sessions while preserving callers' explicit true or false settings. Null handling, create/resume parity, separation from programmatic approval hooks, and focused unit coverage constrain the changed behavior. No Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Motivation & Context
Ensure enable file hooks defaults to false
Description & Review Guide
Ensure enable file hooks defaults to false
Related Issue
Fixes #
AI Assistance
AI assistance details:
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.