Add TypeScript declaration file for messageformat module#63025
Closed
aprameyak wants to merge 1 commit into
Closed
Add TypeScript declaration file for messageformat module#63025aprameyak wants to merge 1 commit into
aprameyak wants to merge 1 commit into
Conversation
Member
|
This is not what #23185 was about, this was only an example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a custom TypeScript declaration file for the messageformat JavaScript library, which does not provide its own type definitions. By declaring the module "messageformat" with proper types, this change allows TypeScript projects to import and use the library without compilation errors. It defines the Msg type for compiled messages and the MessageFormat interface with a constructor and compile method, and provides a default export for convenient usage. This change ensures compatibility with TypeScript 2.8+ and can be placed under src/types/messageformat/index.d.ts for custom type resolution. Resolves #23185.