Add TestFailingCompletionHandlerCrashesProcess Test - #2309
Open
kythant wants to merge 2 commits into
Open
Conversation
Sergio0694
reviewed
Mar 2, 2026
Sergio0694
force-pushed
the
user/kythant/TestFailingCompletionHandlerCrashesProcess
branch
from
June 19, 2026 21:16
67f1e18 to
9d721c8
Compare
Sergio0694
force-pushed
the
user/kythant/TestFailingCompletionHandlerCrashesProcess
branch
from
July 31, 2026 20:43
613b23f to
33cefde
Compare
Sergio0694
enabled auto-merge (squash)
July 31, 2026 20:49
The previous test asserted that the process survives a 'Completed' handler failing with 'E_FAIL', which is the opposite of the intended behavior: any 'HRESULT' outside the well known disconnect allow-list is rethrown on the thread pool by 'ExceptionDispatchInfoExtensions.ThrowAsync', tearing down the process. That made the test fail by killing the whole unit test run. Cover the behavior that was actually implemented instead (see #1969 and #2399/#2400), ie. that failures from a completion handler indicating the peer process is gone are swallowed. The test component now takes the 'HRESULT' to fail with, and exposes a flag set right before the handler throws, so the test can wait for the handler deterministically. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0ad9ec63-3e5f-4e9a-be7f-e1769e060136
Sergio0694
force-pushed
the
user/kythant/TestFailingCompletionHandlerCrashesProcess
branch
from
July 31, 2026 22:23
33cefde to
a89a091
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.