R1 Neo: Disable blue LED to save power#2601
Open
Pawka wants to merge 1 commit into
Open
Conversation
Sometimes, when device is disconnected from phone, the blue LED turns on and does not shut down even when the app connects to the companion again. Sending a message turns off the LED. This does not happen all the time when phone is disconnected and unfortunately I do not know how to reproduce. But other users in old Discord instance also confirmed the same issue. The main problem is that turned on LED drain the battery. I've checked, other variants of the same just disable this LED at all, so followed the same pattern here. Tested the firmware on my own device.
Pawka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, when device is disconnected from phone, the blue LED turns on and does not shut down even when the app reconnects to the companion again. Sending a message turns off the LED. This does not happen all the time when phone is disconnected and unfortunately I do not know how to reproduce. But other users in old Discord instance also confirmed the same issue.
The main problem is that turned on LED drain the battery.
I've checked, other variants of the same board just disable this LED at all and followed the same pattern here. Tested the firmware on my own device.