Add indexSize and usedIndexSize to index stats - #1276
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe SDK adds ChangesIndex statistics fields
Documentation formatting
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR adds optional per-index size fields while preserving compatibility with older responses; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@Strift The ruff check was failing on README and CONTRIBUTING file, but that had nothing to do with this PR, I have run the linter check on those 2 files also so the tests now all pass. Let me know if I should revert that particular commit. Without that commit linter check fails on README and CONTRIBUTING. Either we remove those files from the ruff check or we merge this PR so the lint check stops failing. Thanks! |
I think you can keep these changes in this PR. The new version of Ruff now supports more advanced formatting, even for code blocks in the README, so I don't think it's an issue. |
Pull Request
Related issue
Fixes #1274
What does this PR do?
Adds
indexSizeandusedIndexSizeto the per-index stats response, matching Meilisearch v1.53.0.IndexStatsnow exposes optionalindex_size/used_index_sizefieldssizeFormat=humanNonewhen absent, remaining backward compatible with older Meilisearch versionsPR checklist
Please check if your PR fulfills the following requirements:
Used opencode (AI coding assistant) to implement the model changes and update tests. All changes reviewed and verified by the author against a live Meilisearch v1.53.1 instance.
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit