Hahn banach 2026#1889
Conversation
9ab80d8 to
953d96a
Compare
54625d4 to
846ab42
Compare
c18bf37 to
323445b
Compare
224e82e to
18f2a80
Compare
065e12f to
6344896
Compare
23fe018 to
50b1d73
Compare
50b1d73 to
6cd0728
Compare
29f8562 to
6828184
Compare
cad6d8a to
e743b1e
Compare
6f206e0 to
afc2945
Compare
|
I made a pass on the file: moving a few lemmas to Since TODO: move the new structures out of this file. |
|
Compilation is fine with MathComp 2.5.0 but it looks like with a problem with the duplication of the It this is really the case, is there a trick to make it compile with both versions? @CohenCyril @gares |
Like a "the version 2.X.Y of MathComp only" option? |
|
we tried this trick to cheat the CI: 4d044c8 but nix fails for other reasons so this is not yet conclusive |
b833946 to
bfce795
Compare
| HB.instance Definition _ := SubLmodule_isSubNormedmodule.Build _ _ _ U. | ||
| HB.end. | ||
|
|
||
| (* TODO : use a lightweight factory to make every subLmodType a subnormedmodtype *) |
There was a problem hiding this comment.
@mkerjean Can this comment be removed? It looks like we have addressed the TODO by creating the factory SubLmodule_isSubNormedmodule (just above in this file).
There was a problem hiding this comment.
SubLmodule_isSubNormedmodule can indeed turn a given subLmodule into a subnormedmottype, but we struggled to define a lightweight factory doing so, because of a dependency on K. I would leave that comment - or create an issue.
|
I completed a pass of cleaning. As far as I am concerned, the scripts are good enough. |
The solution that uses isTmp in the SubNormedModule mixin apparently isn't enough to make the CI green. Should it still be left in the definition of substructures? |
I am not sure. The CI error look unrelated, they seem to be related with some build process within nix. |
Motivation for this change
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers