Show MR tags in review pane without requiring a refresh#2851
Draft
CollinBeczak wants to merge 1 commit into
Draft
Show MR tags in review pane without requiring a refresh#2851CollinBeczak wants to merge 1 commit into
CollinBeczak wants to merge 1 commit into
Conversation
Request `includeTags=true` when fetching a task for review (both `fetchTaskForReview` and `loadNextReviewTask`) so the tags arrive with the task payload from the matching backend change. Also fix a state-tracking bug in `ReviewTaskControls.componentDidUpdate`: the task-switch branch could set `state.tags` to `""` (empty string) when the next task arrived without tags, after which the `state.tags === null` guard prevented later-arriving tags from ever populating. Use `!state.tags` and `tags || null` so empty-string state is treated the same as null. Fixes rdar://120004366.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request
includeTags=truewhen fetching a task for review (bothfetchTaskForReviewandloadNextReviewTask) so the tags arrive with the task payload from the matching backend change.Also fix a state-tracking bug in
ReviewTaskControls.componentDidUpdate: the task-switch branch could setstate.tagsto""(empty string) when the next task arrived without tags, after which thestate.tags === nullguard prevented later-arriving tags from ever populating. Use!state.tagsandtags || nullso empty-string state is treated the same as null.