Skip to content

Feature/license admin - #57

Merged
magmacomputing merged 2 commits into
mainfrom
feature/license-admin
Jul 8, 2026
Merged

Feature/license admin#57
magmacomputing merged 2 commits into
mainfrom
feature/license-admin

Conversation

@magmacomputing

@magmacomputing magmacomputing commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes

    • Improved license handling so administrative access is tracked separately, reducing incorrect license/permission information appearing in the app.
    • Prevented outdated role information from lingering after license updates.
  • Chores

    • Bumped the package version to 3.7.1.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6ca5b3a2-82aa-4b99-9bde-7f5568872de0

📥 Commits

Reviewing files that changed from the base of the PR and between 083aef8 and ad92da3.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (6)
  • package.json
  • packages/library/package.json
  • packages/tempo/CHANGELOG.md
  • packages/tempo/package.json
  • packages/tempo/src/plugin/license/license.manager.ts
  • packages/tempo/src/tempo.type.ts

📝 Walkthrough

Walkthrough

License types add an optional role field, which the license manager now sets from JWT claims or deletes when absent, preventing stale role data. Changelog documents the fix as v3.7.1, and package versions are bumped from 3.7.0 to 3.7.1 across root, library, and tempo packages.

Changes

License Role Claim Isolation

Layer / File(s) Summary
License type definitions
packages/tempo/src/tempo.type.ts
Adds optional role?: string property to Internal.ValidationResult and Internal.LicenseState.
License manager role propagation
packages/tempo/src/plugin/license/license.manager.ts
setLicense and the onResolve handler set license.role from claims/result when present, or delete license.role to avoid stale values.
Changelog and version bump
packages/tempo/CHANGELOG.md, package.json, packages/library/package.json, packages/tempo/package.json
Adds a 3.7.1 changelog entry describing the JWT role isolation fix and bumps package versions from 3.7.0 to 3.7.1.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • magmacomputing/magma#31: Both PRs modify Tempo's licensing/JWT handling by extending the license/validation result shape and propagating decoded JWT fields into license state.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the license-admin changes, but it is too vague to clearly describe the main update. Use a more specific title that mentions the license role/JWT payload change, such as moving admin role data into a dedicated claim.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/license-admin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@magmacomputing
magmacomputing merged commit eeccb0c into main Jul 8, 2026
2 checks passed
@magmacomputing
magmacomputing deleted the feature/license-admin branch July 8, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant