Fix point calculation for twoWayOffset due to wrong angle direction#53
Open
OdNairy wants to merge 1 commit into
Open
Fix point calculation for twoWayOffset due to wrong angle direction#53OdNairy wants to merge 1 commit into
OdNairy wants to merge 1 commit into
Conversation
cbd30a2 to
ecbe2ae
Compare
Author
|
@keith @gabriellanata Added GitHub Actions fixes |
b089718 to
4404c8d
Compare
gabriellanata
left a comment
Contributor
There was a problem hiding this comment.
I think i'm a little confused on what this fixes. Seems like its working correctly right now: See the HandTests.testViewRotationGesture() test. The view rotates as expected. Are you specifying degrees or radians when trying to use this function?
Author
|
@gabriellanata It is the fix for let angle = -35 * (Double.pi / 180.0)
try eventGenerator.fingerPinch(fromDistance: 20, toDistance: 200, angle: angle, duration: 3) |
Author
|
@gabriellanata are you still confident that it's not an issue? |
3538b7d to
fd61396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address incorrect calculation for a
twoWayOffsetfunction. Expected behaviour (I guess) was to have two touches with 180° with configurable angle to the horizont.After PR
fix.angle.mov
Before
Here is how it looks like for angle = 0:
horizontal.mov
And this is what we have for a 35 degrees angle:
angle.mov