Repository navigation
feat: add history filter - #610
Open
ECWireless wants to merge 9 commits into
Open
ECWireless wants to merge 9 commits into
ECWireless wants to merge 9 commits into
Conversation
* feat: add history filter to user account * fix: apply linter and prettier * fix: add margin on popover from window * fix: add UI changes to filter * fix: remove auto scroll * fix: remove lint error --------- Co-authored-by: ECWireless <40322776+ECWireless@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an event-type filter UI to the Account History view so users can narrow the displayed history entries by transaction/event type.
Changes:
- Introduces a
useHistoryFilterhook to manage selected event types, filtered results, and popover open/close behavior. - Adds a
HistoryFilterpopover component (with a new filter icon) and wires it intocomponents/HistoryView. - Updates history rendering to use the filtered event list and show an empty-state message when no events match.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| hooks/index.tsx | Re-exports the new history filter hook from the hooks barrel. |
| hooks/filter/useHistoryFilter.ts | Implements filter state + memoized filtering + auto-close behavior on outside scroll. |
| components/Icons/FilterIcon.tsx | Adds a small SVG filter icon used by the filter button. |
| components/HistoryView/index.tsx | Integrates the filter hook/component and switches rendering from mergedEvents to filteredEvents. |
| components/HistoryView/HistoryFilter.tsx | Implements the filter popover UI (trigger, header actions, event-type list). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
rickstaa
previously approved these changes
Oct 6, 2026
rickstaa
left a comment
rickstaa
left a comment
Member
There was a problem hiding this comment.
@ECWireless looks clean to me. I only have two comments:
- Please also add the author of #720 as a co-author. Due to some unclear communication, we accidentally had two people working on this in parallel.
- Could you add support for selecting the filters via query parameters? This would make it easier to link directly to specific votes from places in the Explorer that reference the vote history. If you can link these places to the right url that would also be great.
Once those are addressed, we can merge.
Restore event filters from query parameters and update the URL with shallow navigation when filters change. Link governance participation and voting modals to the matching account history filters, and select account tabs from the pathname so query strings do not hide the History view. Co-authored-by: Moudi Network <lpt@moudi.network>
Collaborator
Author
2 of 4 tasks
Apply selections optimistically so rapid toggles and Clear use the latest selection before a shallow route change finishes. Only the latest navigation can release that selection back to the URL, preserving browser navigation and restoring the URL state after a failed or cancelled push. Add delayed-navigation regression tests and await navigation in the HistoryView integration tests.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The filtering behavior, URL synchronization, loading states, and edge cases are implemented consistently and covered by focused tests.
Review effort: Balanced
Findings: None
Resolved since last review (1)
rickstaa
approved these changes
Oct 7, 2026
rickstaa
left a comment
rickstaa
left a comment
Member
There was a problem hiding this comment.
Thanks, for applying my suggestions.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #513 for all details. Original PR created by @Roaring30s .