Repository navigation
chore: remove the v1 health score Snowflake sink (IN-1222) - #4921
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Merge depends on external production sign-off and deprecation prerequisites that cannot be verified from this diff.
0 open findings
What changed in this PR
Removes the deprecated v1 health-score Kafka export after downstream migration to v2.
Changes:
- Deletes the production-only
health_score_sinkTinybird pipe. - Retains its datasource and v2 sink.
| File | Description |
|---|---|
services/libs/tinybird/pipes/health_score_sink.pipe |
Removes the scheduled v1 Kafka sink. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Delete health_score_sink.pipe. Its v2 fields are already exported by health_score_v2_sink. The live Tinybird pipe and its 00:30 schedule need `tb pipe rm health_score_sink` on production. Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
dc2ae53 to
b91a223
Compare
PR SummaryMedium Risk Overview After deploy, Reviewed by Cursor Bugbot for commit 12e840a. Bugbot is set up for automated code reviews on this repo. Configure here. |
…health-score-sink Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Summary
pipes/health_score_sink.pipe. Each day at 00:30 UTC it exported the v1 health score to thehealth_score_sinkKafka topic. The v2 export,health_score_v2_sink, already carries the v2 fields this pipe exported.lfx-oracle-kafka-streamingconnection, so staging never had it.health_score_sinksource. lf-dbt PR 2 moves the v2 columns to the v2 sink, and lf-dbt PR 4 removes the source. This PR waits for both.health_score_copy_ds, stays until crowd.dev PR 3. The Snowflake tables and the connector topic are human steps below.Deploy notes
Prerequisites
health_score_sink.Steps
Prod only. Staging never had this pipe.
tb pipe ls.health_score_sinkfrom the Snowflake sink connector (crowd-kube connector runbook), confirm the connector tasks are RUNNING, and delete the OCI streamhealth_score_sink.Cross-repo order
On hold until org-dashboard retires (expected early November 2026), because it still reads the v1 score through
/api/project?healthScore=true: insights #2375 and #2376, crowd.dev #4922 and #4923 (closed for now, branches kept).What breaks if out of order
health_score_sinksource freshness check (error_after: 1 day) fails the dbt Cloud job, and the silver health leg goes stale.Related PRs
JIRA
IN-1222: Deprecate v1 health score sinks and tables
https://linuxfoundation.atlassian.net/browse/IN-1222