fix: value.match is not a function with .po files#593
Closed
aroman wants to merge 1 commit intolingodotdev:mainfrom
Closed
fix: value.match is not a function with .po files#593aroman wants to merge 1 commit intolingodotdev:mainfrom
aroman wants to merge 1 commit intolingodotdev:mainfrom
Conversation
Contributor
|
Thanks 🙌 I will test this locally and review later today. |
mathio
approved these changes
Mar 31, 2025
e40c985 to
a4617e0
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/cli/src/cli/loaders/variable/index.ts:28
- [nitpick] Skipping non-string values may hide unexpected data issues; consider adding a comment or logging to clarify why these values are being skipped for easier future debugging.
if (typeof value !== "string") {
Author
|
@mathio thanks for the reply. I dont think this PR should be merged as-is - it was just a quick hack as I mentioned to illustrate the problem. Probably a bit deeper digging into why the types are not as expected is warranted here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is just a quick and dirty workaround. to fix i18n --frozen not working with .po files. see #592