Skip to content

fix: value.match is not a function with .po files#593

Closed
aroman wants to merge 1 commit intolingodotdev:mainfrom
magic-circle-studio:main
Closed

fix: value.match is not a function with .po files#593
aroman wants to merge 1 commit intolingodotdev:mainfrom
magic-circle-studio:main

Conversation

@aroman
Copy link
Copy Markdown

@aroman aroman commented Mar 27, 2025

this is just a quick and dirty workaround. to fix i18n --frozen not working with .po files. see #592

@mathio
Copy link
Copy Markdown
Contributor

mathio commented Mar 28, 2025

Thanks 🙌 I will test this locally and review later today.

Copy link
Copy Markdown
Contributor

@mathio mathio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @aroman looks good 🚀

In order for PR checks to pass and release this change please run pnpm new in repo root to add a new changeset. I tried adding it for you, but I dont have write permissions to your fork.

Sorry I missed this one last week.

@mathio mathio force-pushed the main branch 2 times, most recently from e40c985 to a4617e0 Compare April 2, 2025 10:05
@maxprilutskiy maxprilutskiy requested a review from Copilot April 4, 2025 19:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

packages/cli/src/cli/loaders/variable/index.ts:28

  • [nitpick] Skipping non-string values may hide unexpected data issues; consider adding a comment or logging to clarify why these values are being skipped for easier future debugging.
if (typeof value !== "string") {

@aroman
Copy link
Copy Markdown
Author

aroman commented Apr 7, 2025

@mathio thanks for the reply. I dont think this PR should be merged as-is - it was just a quick hack as I mentioned to illustrate the problem. Probably a bit deeper digging into why the types are not as expected is warranted here.

@mathio mathio closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants