refactor: move gitConfig logic to parent and call it in child using super.gitConfig()#590
Merged
maxprilutskiy merged 7 commits intolingodotdev:mainfrom Apr 9, 2025
Merged
refactor: move gitConfig logic to parent and call it in child using super.gitConfig()#590maxprilutskiy merged 7 commits intolingodotdev:mainfrom
maxprilutskiy merged 7 commits intolingodotdev:mainfrom
Conversation
…ab, and BitBucket
SXsid
changed the title
mathio
force-pushed
the
main
branch
2 times, most recently
from
e40c985 to
a4617e0
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
action/src/platforms/_base.ts:27
- [nitpick] Consider specifying an explicit return type (e.g., void) for gitConfig in the base class to ensure consistency and clarity with its usage in the child classes.
gitConfig(token?: string, repoUrl?: string) {
action/src/platforms/gitlab.ts:96
- [nitpick] Ensure that the token and URL being passed to super.gitConfig are always valid; if there's any possibility of them being empty or null, additional validation might be needed.
super.gitConfig(glToken, url);
Contributor
|
fantastic job @SXsid ! |
mainstar123
pushed a commit
to mainstar123/lingo.dev
that referenced
this pull request
Jul 7, 2025
…uper.gitConfig() (lingodotdev#590) * fix(git): add more robust error handling for Git operation * revert: multi-platform refactoring to align with issue changes requested * fix(action): refactor gitConfig to reduce redundancy for GitHub, GitLab, and BitBucket * refactor: remove unnecessary imports --------- Co-authored-by: Max Prilutskiy <5614659+maxprilutskiy@users.noreply.github.com>
17prateek12
pushed a commit
to 17prateek12/lingo.dev
that referenced
this pull request
Jan 23, 2026
…uper.gitConfig() (lingodotdev#590) * fix(git): add more robust error handling for Git operation * revert: multi-platform refactoring to align with issue changes requested * fix(action): refactor gitConfig to reduce redundancy for GitHub, GitLab, and BitBucket * refactor: remove unnecessary imports --------- Co-authored-by: Max Prilutskiy <5614659+maxprilutskiy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#581 move gitConfig logic to parent and execute in child using super.gitConfig()