Skip to content

refactor: Added JSDoc comments to exported functions in locales.ts#588

Closed
sidhuiwnl wants to merge 2 commits intolingodotdev:mainfrom
sidhuiwnl:sid/adding-jsdoc
Closed

refactor: Added JSDoc comments to exported functions in locales.ts#588
sidhuiwnl wants to merge 2 commits intolingodotdev:mainfrom
sidhuiwnl:sid/adding-jsdoc

Conversation

@sidhuiwnl
Copy link
Copy Markdown
Contributor

fixes #559

@sidhuiwnl sidhuiwnl changed the title Added JSDoc comments to exported functions in locales.ts refactor: Added JSDoc comments to exported functions in locales.ts Mar 26, 2025
Copy link
Copy Markdown
Contributor

@mathio mathio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep PRs focused on single issue to make them easier to review. This includes changes for 2 issues.

Comment thread .changeset/big-moons-design.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one file in here is needed. Please delete this one.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread packages/cli/src/cli/cmd/cleanup.ts Outdated
Comment on lines +14 to +15
.option("--locale <locale>", "Clean up only the specified target locale.If not provided, processes all target locales.")
.option("--bucket <bucket>", " Clean up only the specified bucket type.If not provided, processes all buckets.")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.option("--locale <locale>", "Clean up only the specified target locale.If not provided, processes all target locales.")
.option("--bucket <bucket>", " Clean up only the specified bucket type.If not provided, processes all buckets.")
.option("--locale <locale>", "Clean up only the specified target locale")
.option("--bucket <bucket>", " Clean up only the specified bucket type")

Lets not make this too verbose.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok changed

Comment on lines +27 to +34
.option("--key <key>", "Key to process.Process only a specific translation key. Useful for debugging or updating a single entry.")
.option("--frozen", `Run in read-only mode - fails if any translations need updating.Useful for CI/CD pipelines to detect missing translations.`)
.option("--force", "Ignore lockfile and process all keys, forcing a full re-translation.Use with caution as this may incur higher API costs.")
.option("--verbose", "Show detailed output including intermediate processing data and API communication details.")
.option("--interactive", "Enable interactive mode for reviewing and editing translations before they are applied.")
.option("--api-key <api-key>", "Explicitly set the API key to use.Override the default API key from settings.")
.option("--debug", "Pause execution at start for debugging purposes.Waits for user confirmation before proceeding.")
.option("--strict", "Stop processing on first error instead of continuing with other locales/buckets.")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an empty space after period at the end of a sentence when another sentence follows.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have changed everything you mentioned. can i commit the changes

@sidhuiwnl sidhuiwnl closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec Module (/packages/spec): Add JSDoc comments to exported functions in locales.ts

2 participants