-
Notifications
You must be signed in to change notification settings - Fork 837
refactor(action): reduce redundancy in gitConfig for GitHub, GitLab and BitBucket #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "lingo.dev": patch | ||
| --- | ||
|
|
||
| [Refactor]: This PR creates a git-utils file in the /action/src to remove the redundancy inside the gitConfig() function of Github, Gitlab and Bitbucket. This PR refactors the code to reduce redundancy of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { execSync } from "child_process"; | ||
|
|
||
| export function configureGitCredentials(token: string, repoUrl: string): boolean { | ||
| if (!token) { | ||
| console.error("Missing token. Unable to configure Git credentials."); | ||
| return false; | ||
| } | ||
| try { | ||
| execSync(`git remote set-url origin ${repoUrl}`, { stdio: "inherit" }); | ||
| console.log("Git credentials configured successfully."); | ||
| return true; | ||
| } catch (error) { | ||
| if (error instanceof Error) { | ||
| console.error(`Failed to configure git credentials: ${error.message}`); | ||
| } else { | ||
| console.error("An unknown error occurred while configuring Git credentials.", error); | ||
| } | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| export function configureBitbucketProxy(origin: string, proxyUrl: string): void { | ||
| try { | ||
| execSync(`git config --unset http.${origin}.proxy`, { stdio: "inherit" }); | ||
| execSync(`git config http.${origin}.proxy ${proxyUrl}`, { stdio: "inherit" }); | ||
| console.log("Bitbucket proxy configured successfully."); | ||
| } catch (error) { | ||
| if (error instanceof Error) { | ||
| console.error(`Failed to configure Bitbucket proxy: ${error.message}`); | ||
| } else { | ||
| console.error("An unknown error occurred while configuring the Bitbucket proxy.", error); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gitConfig function currently has a mixed return type (Promise | void) and relies on console error logging to signal failure. Consider standardizing the return type and error handling approach (for example, by throwing an exception or consistently returning a boolean) across all platform implementations.