chore(packages/spec): add precise types for locales.ts#580
Merged
mathio merged 5 commits intolingodotdev:mainfrom Mar 26, 2025
Merged
chore(packages/spec): add precise types for locales.ts#580mathio merged 5 commits intolingodotdev:mainfrom
mathio merged 5 commits intolingodotdev:mainfrom
Conversation
mathio
approved these changes
Mar 26, 2025
| }; | ||
|
|
||
| export function normalizeLocale(locale: string) { | ||
| export function normalizeLocale(locale: string): string { |
Contributor
There was a problem hiding this comment.
This is not necessary since Typescript automatically infers simple types like this. But it also does not hurt to be explicit since the method is exported from the lib 🙃
Contributor
|
Please resolve conflicts and we can merge this! |
mainstar123
pushed a commit
to mainstar123/lingo.dev
that referenced
this pull request
Jul 7, 2025
17prateek12
pushed a commit
to 17prateek12/lingo.dev
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #560