Skip to content

feat: identify the VASP that custodies a crypto wallet account #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyav merged 6 commits into from
Aug 20, 2026
Merged

feat: identify the VASP that custodies a crypto wallet account #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e433f00
feat: add custody type and VASP link to external accounts
shreyav Aug 13, 2026
ccff0de
Identify custodying VASP by canonical name, matching the discovery pa…
shreyav Aug 13, 2026
0660062
Merge main
shreyav Aug 14, 2026
eec9000
Scope custodyType and vaspName to crypto wallet accounts
shreyav Aug 20, 2026
22135b6
Merge main
shreyav Aug 20, 2026
1b83fc7
Infer custody from vaspName and drop the transfer error code
shreyav Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .stainless/stainless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ resources:
external_account: '#/components/schemas/ExternalAccount'
external_account_create: '#/components/schemas/ExternalAccountCreateRequest'
external_account_info_one_of: "#/components/schemas/ExternalAccountInfoOneOf"
wallet_custody_fields: "#/components/schemas/WalletCustodyFields"
business_beneficiary: "#/components/schemas/BusinessBeneficiary"
wallet_beneficiary_fields: "#/components/schemas/WalletBeneficiaryFields"
wallet_beneficiary_one_of: "#/components/schemas/WalletBeneficiaryOneOf"
Expand Down
14 changes: 14 additions & 0 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion openapi/components/schemas/external_accounts/BaseWalletExternalAccountInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ title: Base Wallet
allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/BaseWalletInfo.yaml

- $ref: ./WalletBeneficiaryFields.yaml
- $ref: ./WalletCustodyFields.yaml
1 change: 1 addition & 0 deletions openapi/components/schemas/external_accounts/EthereumWalletExternalAccountInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/EthereumWalletInfo.yaml
- $ref: ./WalletBeneficiaryFields.yaml
- $ref: ./WalletCustodyFields.yaml
1 change: 1 addition & 0 deletions openapi/components/schemas/external_accounts/PlasmaWalletExternalAccountInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/PlasmaWalletInfo.yaml
- $ref: ./WalletBeneficiaryFields.yaml
- $ref: ./WalletCustodyFields.yaml
2 changes: 1 addition & 1 deletion openapi/components/schemas/external_accounts/PolygonWalletExternalAccountInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ title: Polygon Wallet
allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/PolygonWalletInfo.yaml

- $ref: ./WalletBeneficiaryFields.yaml
- $ref: ./WalletCustodyFields.yaml
2 changes: 1 addition & 1 deletion openapi/components/schemas/external_accounts/SolanaWalletExternalAccountInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ title: Solana Wallet
allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/SolanaWalletInfo.yaml

- $ref: ./WalletBeneficiaryFields.yaml
- $ref: ./WalletCustodyFields.yaml
2 changes: 1 addition & 1 deletion openapi/components/schemas/external_accounts/SparkWalletExternalAccountInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ title: Spark Wallet
allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/SparkWalletInfo.yaml

- $ref: ./WalletBeneficiaryFields.yaml
- $ref: ./WalletCustodyFields.yaml
2 changes: 1 addition & 1 deletion openapi/components/schemas/external_accounts/TronWalletExternalAccountInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ title: Tron Wallet
allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/TronWalletInfo.yaml

- $ref: ./WalletBeneficiaryFields.yaml
- $ref: ./WalletCustodyFields.yaml
10 changes: 10 additions & 0 deletions openapi/components/schemas/external_accounts/WalletCustodyFields.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
type: object
properties:
vaspName:
type: string
Comment on lines +3 to +4

@greptile-apps greptile-apps Bot Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Empty VASP name breaks custody classification

When a client creates a wallet with vaspName: "", the schema accepts a present value that names no VASP, causing the account either to be misclassified as VASP-hosted or to fail undocumented server-side validation.

Suggested change
vaspName:
type: string
vaspName:
type: string
minLength: 1
Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/WalletCustodyFields.yaml
Line: 3-4

Comment:
**Empty VASP name breaks custody classification**

When a client creates a wallet with `vaspName: ""`, the schema accepts a present value that names no VASP, causing the account either to be misclassified as VASP-hosted or to fail undocumented server-side validation.

```suggestion
  vaspName:
    type: string
    minLength: 1
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

description: >-
Name of the VASP that custodies this account, from the VASP directory
(`GET /vasps`). Present when the wallet is held at an exchange or other
custodial platform; omit it for self-custody wallets. Ownership
verification applies only to self-custody wallets.
example: Kraken
Loading