fix(providers): correct Qwen3.8 reasoning levels - #1304
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Approved the pending Cross-platform CI run at this exact head, and it came back green. Worth explaining the silence beforehand: contributor PRs queue their workflow runs as To be precise about what this does and does not do: it only unblocks CI. It does not make this mergeable. The four-box readiness checklist in the description is your attestation, and the gate keeps the PR in draft until you complete it. With CI now green at your head, box 1 is provable. If anything in the run looks wrong to you, say so and I will dig into it rather than leaving you to guess. |
83c9805 to
b921e34
Compare
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
Landed on Your finding was correct: modelReasoningEfforts: { "QWEN3.8-MAX": ["low", "high", "xhigh"] },
expect(provider.modelReasoningEfforts["QWEN3.8-MAX"]).toBeUndefined();This repo keeps registry defaults beneath user entries, so a deliberately configured Qwen3.8 override has to survive. The correction delivers the right contract without removing user overrides, and the tests now assert the correct behavior: the stale generated default is fixed while an explicit per-model override is preserved. Red ablation confirmed both regressions fail without the fix (the uppercase budget entry gets deleted and the custom ladder gets replaced). Full suite green on the landed head. Thanks — the contract research and the doc links were solid; only the ownership rule needed adjusting. |
Summary
low,medium, andxhighlevels, withxhighas the default.reasoning_effortfield instead of the legacy Qwenthinking_budgetcontract in both Beijing and international presets.highormaxvalues.The previous registry data classified Qwen3.8-Max like older Qwen3.x budget models. International metadata also exposed
highwhile omitting the supportedmediumtier. Existing provider rows persist capability metadata, so correcting only the registry seed would leave upgraded installations on the stale wire contract.This change makes new and existing Alibaba Token Plan configurations follow the Qwen3.8-Max documentation. Codex compatibility levels above the upstream ladder clamp to
xhighrather than reaching the provider as unsupported values.Verification
bun test tests/reasoning-effort.test.ts tests/alibaba-intl-token-plan.test.ts tests/provider-registry-parity.test.ts— 89 passed, 0 failed.bun run test— 10,132 passed, 7 skipped, 0 failed across 631 files.bun run typecheckbun run privacy:scancd docs-site && bun run buildgit diff --checkChecklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.