Repository navigation
Flag repeated Associate pairs and show chip-list errors once - #6361
Open
rtibblesbot wants to merge 2 commits into
Open
rtibblesbot wants to merge 2 commits into
rtibblesbot wants to merge 2 commits into
Conversation
- A pair with the same two items as another, in either order, is now an error on both pairs - Distractor message now reads "Distractors cannot match an existing item or distractor" Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- EditableChipList lists each distinct message once under the box instead of under every chip - Flagged chips show an error icon and are described by their message via ClickableRegion's new ariaDescribedby Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-6316-d6caa1
branch
from
October 30, 2026 22:26
ea4fc2b to
0be866c
Compare
rtibblesbot
marked this pull request as ready for review
October 30, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #6316. Decisions: #6316 (comment)
Reviewer guidance
Suggested review: Full code review, then manual QA once the reviewer sets Needs QA.
contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ClickableRegion/index.vue,contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/EditableChipList/index.vue,contentcuration/contentcuration/frontend/shared/views/QTIEditor/constants.js,contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/Editor.vue,contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/validation.js….role="alert"message stays silent when a third chip gains a message that is already shown.New exercise in an editable channel > Questions tab > "New question".
Kenya/Nairobi. Add distractorKenya, click "Save". Chip gets red border and error icon; "Distractors cannot match an existing item or distractor" shows below the box.Kenyachip. Editor opens with no error icon.Lima; "Save" does not move. Click "Save". Chip closes, message goes.Peru, click the × next to the editor. No chip added.Nairobi/Kenya. Both rows show "Pairs cannot repeat another pair"; question shows "Incomplete".Kenya/Lagos. Both rows clear.Mammaltwice to one row. Message shows once, below that row.Redtwice. Message shows once.Look out for:
Open questions:
role="alert"; a chip gaining an error is announced once via the KDS live region.axe (WCAG 2.2 AA): only
color-contraston the unchanged "Add pair/row/distractor" button text.Evidence
Associate distractors: edit, save and discard a flagged chip
Tokyodistractor flagged: red border, error icon, one message below the boxTokyodraft saved as a flagged chipassociate-distractor-chip-save-discard-flow.webm
More captures (19)
Birdand bothFishflaggedAI usage
Claude Code implemented the validation,
EditableChipListchanges and tests from the maintainer's decisions. Verified with the QTI editor Jest suite, pre-commit, screenshots and an axe audit.Written by rtibblesbot, an LLM-based coding agent.
🟡 Waiting for feedback
Last updated: 2026-10-30 22:30 UTC