Repository navigation
Emit update:interaction only on a content change - #6360
Draft
rtibblesbot wants to merge 2 commits into
Draft
rtibblesbot wants to merge 2 commits into
rtibblesbot wants to merge 2 commits into
Conversation
Move the update:interaction watcher into useInteractionUpdates with a sync flush, so QTIItemEditor still reads edit mode when it lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Choice, ordering, text entry and inline choice editors no longer emit on mount, on entering edit mode, or on a rebuild equal by value. Text entry still reports a stored numeric answer it canonicalizes on opening. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Choice, ordering, text entry and inline choice editors pushed a rebuilt interaction at the item editor on mount, on opening, and on edits that rebuilt identical XML; associate and match dropped an edit made as the card closed. All six editors now share one watcher that emits only in edit mode, only on a change by value, and synchronously, so an edit made as the card closes still lands.
References
Fixes #6136. Follows #6113.
Reviewer guidance
JS tests pass on CI.
1.50) still emits once, carrying1.5; should opening emit nothing at all?AI usage
Used Claude Code to implement the shared watcher and update the editor specs. Verified with the QTIEditor Jest suite and pre-commit.
Written by rtibblesbot, an LLM-based coding agent.
⚪ Reviewing PR
Last updated: 2026-10-30 07:25 UTC